Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed deprecated process sorting methods from OperatingSystem class. #1725

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

varnaa
Copy link
Contributor

@varnaa varnaa commented Oct 1, 2021

Removed deprecated process sorting methods from the OperatingSystem class. Task 5 in issue #1723.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and approve this PR. For future reference, there are a lot of "whitespace" changes based on IDE indentation settings which I'd prefer to avoid in future PRs.

@dbwiddis dbwiddis added the hacktoberfest-accepted Accepted during Hacktoberfest label Oct 1, 2021
@dbwiddis dbwiddis force-pushed the remove_deprecated_process_sort branch from 1248caf to c2113eb Compare October 1, 2021 17:33
@coveralls
Copy link

Coverage Status

Coverage increased (+1.09%) to 87.886% when pulling c2113eb on varnaa:remove_deprecated_process_sort into a64855d on oshi:master.

@varnaa
Copy link
Contributor Author

varnaa commented Oct 2, 2021

I'll go ahead and approve this PR. For future reference, there are a lot of "whitespace" changes based on IDE indentation settings which I'd prefer to avoid in future PRs.

@dbwiddis Hey, how would i avoid this "whitespace" in future PRs ?? I am new to this, so can you please hint me towards it ?? I used intellij idea ultimate editor for this PR.

@dbwiddis
Copy link
Member

dbwiddis commented Oct 2, 2021

@varnaa there is an Eclipse formatting file in oshi/oshi-dist/src/main/resources/eclipse/ that I think you can import into IntelliJ. Really it's basically the "Sun Java Conventions" format with 4-character space indent if IntelliJ has something similar.

Alternately you can always look at the diff and identify what's different and manually change the format for this project. I only noted two main differences: Indenting on the @returns javadoc was one difference and the other was that your IDE had only a 4-space indent on a "continuation line" while the OSHI convention does an 8-space indent.

@dbwiddis
Copy link
Member

dbwiddis commented Oct 2, 2021

@varnaa Try this

@varnaa
Copy link
Contributor Author

varnaa commented Oct 2, 2021

@dbwiddis Thanks i will try it.

@varnaa varnaa deleted the remove_deprecated_process_sort branch October 3, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted during Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants