Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed return type of getServices() to return a List #1730

Merged
merged 5 commits into from
Oct 3, 2021
Merged

Changed return type of getServices() to return a List #1730

merged 5 commits into from
Oct 3, 2021

Conversation

adrian-kong
Copy link
Collaborator

this is for #1723

dbwiddis
dbwiddis reviewed Oct 3, 2021
View reviewed changes
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. A few minor requests.

CHANGELOG.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
oshi-core/src/main/java/oshi/software/os/windows/WindowsOperatingSystem.java Outdated Show resolved Hide resolved
dbwiddis
dbwiddis reviewed Oct 3, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
dbwiddis
dbwiddis approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll merge after the tests finish.

@adrian-kong
Copy link
Collaborator Author

epic, could i also do #1727 even though that would be my second PR

@dbwiddis
Copy link
Member

dbwiddis commented Oct 3, 2021

epic, could i also do #1727 even though that would be my second PR

Absolutely. Don’t you get Hactoberfest swag for 4 or something?

@adrian-kong
Copy link
Collaborator Author

yep but found out this is pretty fun

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.856% when pulling b33ce86 on adrian-kong:master into 946d377 on oshi:master.

@dbwiddis dbwiddis merged commit 7b8f780 into oshi:master Oct 3, 2021
@dbwiddis dbwiddis added the hacktoberfest-accepted Accepted during Hacktoberfest label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@sonatype-lift sonatype-lift[bot] sonatype-lift left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted during Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adrian-kong @dbwiddis @coveralls