Changed return type of getMTU() from int to long #1736
Conversation
|
Sorry @dbwiddis I had to create a new PR as the last one was messed up with a lot of branching, also I had to disable my code formatter. I hope you consider this PR. Anyways thank you for the opportunity and patience that you showed. |
|
No problem, the whole purpose of the Hactoberfest issues is for you to learn. This PR looks great. I've got a tweak I'll make to it tonight and then merge it. |
|
I can fix all these with a single mouseclick if you want. :) |
|
@dbwiddis Thank you so much. Appreciate it. 👍🏻 :) |
|
Will merge as soon as tests finish. |
|
I have tried my best to not mess up the code format but if you feel it need some tweaks then go ahead. |
|
Just a few trailing spaces and I moved the MTU test up out of the local tests since the "windows is negative for local interfaces" didn't apply any more. No worries and thanks for the PR! |
Changed return type of the NetworkInterface method getMTU() from int to long in all its OS implementations.