Restrict imports with maven enforcer #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazendaz
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #1802.
WIth the new version I don't have to specify static separately, so the configuration is pretty streamlined. I like that the checkstyle plugin can be very strict on the modular part, allowing this to be a little more lenient. But using enforcer has the advantage of working with mvn test (or most other maven commands), and not requiring a separate "checkstyle:check" call.
Set as draft because it's using a snapshot dependency, but wanted to stick this up here for @mprins and @hazendaz review. Will wait to merge until it's a released version.