-
-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include inactive memory in mac/linux available. #25
Conversation
@@ -8,6 +8,7 @@ Next | |||
* Added Travis-CI - [@dblock](https://github.com/dblock). | |||
* Added TODO list and enhanced README documentation - [@ptitvert](https://github.com/ptitvert) | |||
* [#15](https://github.com/dblock/oshi/pull/15), [#18](https://github.com/dblock/oshi/pull/18): Added support for CPU load - [@kamenitxan](https://github.com/kamenitxan), [@Sorceror](https://github.com/Sorceror). | |||
* Include inactive memory in mac/linux available - [@dbwiddis](https://github.com/dbwiddis). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this something that looks like the line above:
[#25](https://github.com/dblock/oshi/pull/25): Include inactive memory amount in GlobalMemory#getAvailable on Mac/LLinux - [ ... ]
You can commit with --amend
and force push up to avoid having to re-squash things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I didn't have the pull request # until I committed (I suppose I could have guessed). And since I've been committing via svn, I am really unfamiliar with the git command lines to do this. Argh. I'll do my best, I guess... you're really making me have to learn new tools!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an opportunity!
We force this strange construction where you commit, then push, then make a pull request, then amend. It's weird, but it's the best we have for changelog entries that seems to make the customer (the developer reading the changelog) happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that was painful, until I figured out to use the -f switch on my push... I think this is finally all set.
It may be hard, but is there a way to write a test here that would have failed without the code change? Try something? |
For testing, we can try to parse other memory commands.
|
Include inactive memory in mac/linux available.
Merged, looking forward to more! |
Closes #23.