fix #2639: getOwningProcessId sometimes return -1 on 64x linux #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
reviewed
May 24, 2024
| conns.addAll(queryConnections("tcp", 4, pidMap)); | ||
| conns.addAll(queryConnections("tcp", 6, pidMap)); | ||
| conns.addAll(queryConnections("udp", 4, pidMap)); | ||
| conns.addAll(queryConnections("udp", 6, pidMap)); | ||
| return conns; | ||
| } | ||
|
|
||
| private static List<IPConnection> queryConnections(String protocol, int ipver, Map<Integer, Integer> pidMap) { | ||
| private static List<IPConnection> queryConnections(String protocol, int ipver, Map<Long, Integer> pidMap) { |
There was a problem hiding this comment.
You need to parse the inode a few lines down to a long to match this key.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2645 +/- ##
==========================================
- Coverage 86.24% 85.20% -1.05%
==========================================
Files 30 30
Lines 1338 1338
Branches 189 189
==========================================
- Hits 1154 1140 -14
- Misses 103 116 +13
- Partials 81 82 +1 ☔ View full report in Codecov by Sentry. |
yourancc
force-pushed
the
branch_fix_issue
branch
from
3d4a460
to
11a1ba1
Compare
|
Thank you for your feedback. I have made the necessary changes to the code. |
socklen_t is an unsigned (native) long which is 32-bit or 64-bit depending on OS bitness.
dbwiddis
reviewed
May 25, 2024
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ | |||
| [#2625](https://github.com/oshi/oshi/pull/2625): Add part number to Physical Memory - [@BartekDziurowicz](https://github.com/BartekDziurowicz), [@dbwiddis](https://github.com/dbwiddis). | |||
|
|
|||
| ##### Bug fixes / Improvements | |||
| * [#2645](https://github.com/oshi/oshi/pull/2645): fix getOwningProcessId sometimes return -1 on 64x linux - [@yourancc](https://github.com/yourancc). | |||
There was a problem hiding this comment.
This needs to be under the new 6.6.1 section
yourancc
force-pushed
the
branch_fix_issue
branch
from
11a1ba1
to
b0a48e0
Compare
dbwiddis
approved these changes
May 25, 2024
|
thank you for your patient guidance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the issue(#2639 ) where the owning process ID sometimes returns -1 caused by it.