Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serial number to Physical Memory #2646

Merged
merged 3 commits into from
May 25, 2024
Merged

Conversation

tegrason
Copy link
Contributor

new add physical memory of serial number

@tegrason
Copy link
Contributor Author

for issue #2644

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.16%. Comparing base (cad9125) to head (442dbf0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2646      +/-   ##
==========================================
- Coverage   86.24%   85.16%   -1.09%     
==========================================
  Files          30       30              
  Lines        1338     1341       +3     
  Branches      189      189              
==========================================
- Hits         1154     1142      -12     
- Misses        103      116      +13     
- Partials       81       83       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can you add a CHANGELOG entry?

@dbwiddis dbwiddis linked an issue May 24, 2024 that may be closed by this pull request
@tegrason
Copy link
Contributor Author

Looks great! Can you add a CHANGELOG entry?

OKay.

@dbwiddis dbwiddis changed the title New add physical memory of serial number Add serial number to Physical Memory May 25, 2024
@dbwiddis dbwiddis merged commit 7864f6b into oshi:master May 25, 2024
15 checks passed
@tegrason tegrason deleted the issue2644 branch May 25, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hello,how do i obtain memory serial number?
2 participants