Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context switches & interrupts #447

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Add context switches & interrupts #447

merged 1 commit into from
Apr 13, 2018

Conversation

jpbempel
Copy link
Contributor

Add 2 methods in CentralProcessor interface
only Linux implementation provided for now

@codecov-io
Copy link

codecov-io commented Feb 13, 2018

Codecov Report

Merging #447 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #447   +/-   ##
=========================================
  Coverage     83.35%   83.35%           
  Complexity      191      191           
=========================================
  Files            27       27           
  Lines          1376     1376           
  Branches        200      200           
=========================================
  Hits           1147     1147           
  Misses          109      109           
  Partials        120      120
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/oshi/hardware/CentralProcessor.java 100% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cfcf14...6514391. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 13, 2018

Coverage Status

Coverage remained the same at 91.2% when pulling 6514391 on jpbempel:master into 5cfcf14 on oshi:master.

@dbwiddis
Copy link
Member

Is this not applicable/available for other OS's? I'm worried about committing code for only a single OS without a path to trying the others (if possible). Should also file an issue to track this if possible.

You need to implement the new methods in the JSON version as well.

Add 2 methods in CentralProcessor interface
only Win & Linux implementation provided for now
@jpbempel
Copy link
Contributor Author

Added windows implementation, but cannot test on other systems like Mac/Solaris/FreeBSD
However tips for this can be found in https://github.com/giampaolo/psutil/blob/master/psutil/_psutil_osx.c#L1774

Thanks

@oshi oshi deleted a comment Feb 14, 2018
@dbwiddis dbwiddis force-pushed the master branch 5 times, most recently from bd34841 to 0244c70 Compare April 12, 2018 07:31
@dbwiddis dbwiddis merged commit 6e53816 into oshi:master Apr 13, 2018
dbwiddis pushed a commit that referenced this pull request Apr 13, 2018
Add 2 methods in CentralProcessor interface
only Win & Linux implementation provided for now
dbwiddis pushed a commit that referenced this pull request Apr 13, 2018
Add 2 methods in CentralProcessor interface
only Win & Linux implementation provided for now
dbwiddis pushed a commit that referenced this pull request Apr 13, 2018
Add 2 methods in CentralProcessor interface
only Win & Linux implementation provided for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants