Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored unsigned long bitmasking #724

Merged
merged 3 commits into from
Dec 13, 2018
Merged

Refactored unsigned long bitmasking #724

merged 3 commits into from
Dec 13, 2018

Conversation

LiborB
Copy link
Contributor

@LiborB LiborB commented Dec 12, 2018

Refactored unsigned long bitmasking by extracting bitmasking logic to a utility method. Resolves #723

@codecov-io
Copy link

codecov-io commented Dec 12, 2018

Codecov Report

Merging #724 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #724      +/-   ##
============================================
+ Coverage     82.52%   82.53%   +0.01%     
  Complexity      198      198              
============================================
  Files            28       28              
  Lines          1528     1529       +1     
  Branches        225      225              
============================================
+ Hits           1261     1262       +1     
  Misses          128      128              
  Partials        139      139
Impacted Files Coverage Δ Complexity Δ
oshi-core/src/main/java/oshi/util/ParseUtil.java 94.97% <100%> (+0.02%) 0 <0> (ø) ⬇️
...hi-core/src/main/java/oshi/hardware/NetworkIF.java 81.42% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3866c16...77a45dd. Read the comment docs.

@coveralls
Copy link

coveralls commented Dec 12, 2018

Coverage Status

Coverage increased (+0.006%) to 90.451% when pulling 77a45dd on LiborB:refactor-unsigned-long into 3866c16 on oshi:master.

@dbwiddis
Copy link
Member

Looks great! I made a few tweaks and will merge shortly. Thanks for your contribution to open source!

@LiborB
Copy link
Contributor Author

LiborB commented Dec 13, 2018

Thanks for letting me! Will continue to help where I can.

@dbwiddis dbwiddis merged commit 620f900 into oshi:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants