Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate WMI Query Handling from Util #728

Merged
merged 18 commits into from
Jan 5, 2019
Merged

Separate WMI Query Handling from Util #728

merged 18 commits into from
Jan 5, 2019

Conversation

retomerz
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 21, 2018

Codecov Report

Merging #728 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #728   +/-   ##
=========================================
  Coverage     82.64%   82.64%           
  Complexity      198      198           
=========================================
  Files            28       28           
  Lines          1527     1527           
  Branches        224      224           
=========================================
  Hits           1262     1262           
  Misses          127      127           
  Partials        138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1588e9b...8f2fb48. Read the comment docs.

@coveralls
Copy link

coveralls commented Dec 21, 2018

Coverage Status

Coverage remained the same at 90.504% when pulling 8f2fb48 on retomerz:issue716 into 1588e9b on oshi:master.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An initial run-through. Key initial comment is that we should move the instantiation of these new classes out of the top-level SystemInfo class so we don't have to pass arguments around everywhere.

@oshi oshi deleted a comment Jan 5, 2019
@dbwiddis dbwiddis changed the title Issue716 Separate WMI Query Handling from Util Jan 5, 2019
@dbwiddis
Copy link
Member

dbwiddis commented Jan 5, 2019

I went ahead and made most of the changes that I suggested in the code review:

  • Instead of passing the WmiQueryHandler around everywhere as an argument, I made it a singleton.
  • I removed the caching classes you put in -- a lot of bloat for simple string maps. I did update those classes to remove the static initializers though.

@oshi oshi deleted a comment Jan 5, 2019
@dbwiddis dbwiddis merged commit cc57598 into oshi:master Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants