Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use query key to update counters in groups #766

Merged
merged 4 commits into from
Jan 17, 2019
Merged

Use query key to update counters in groups #766

merged 4 commits into from
Jan 17, 2019

Conversation

dbwiddis
Copy link
Member

Fixes #759

@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #766 into master will decrease coverage by 0.15%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #766      +/-   ##
============================================
- Coverage     82.31%   82.15%   -0.16%     
  Complexity      198      198              
============================================
  Files            26       26              
  Lines          1504     1491      -13     
  Branches        221      217       -4     
============================================
- Hits           1238     1225      -13     
  Misses          127      127              
  Partials        139      139
Impacted Files Coverage Δ Complexity Δ
oshi-core/src/main/java/oshi/util/FormatUtil.java 100% <100%> (+1.38%) 0 <0> (ø) ⬇️
...hi-core/src/main/java/oshi/hardware/NetworkIF.java 81.42% <100%> (ø) 0 <0> (ø) ⬇️
oshi-core/src/main/java/oshi/util/ParseUtil.java 95.53% <50%> (-0.52%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ff1c3...7bddf8d. Read the comment docs.

@coveralls
Copy link

coveralls commented Jan 17, 2019

Coverage Status

Coverage decreased (-0.08%) to 90.275% when pulling 7bddf8d on dbwiddis:perf-groups into 34ff1c3 on oshi:master.

@dbwiddis
Copy link
Member Author

This pull request introduces 1 alert and fixes 4 when merging 08643b6 into 34ff1c3 - view on LGTM.com

new alerts:

  • 1 for Spurious Javadoc @param tags

fixed alerts:

  • 2 for Result of multiplication cast to wider type
  • 2 for Dereferenced variable may be null

Comment posted by LGTM.com

@dbwiddis
Copy link
Member Author

This pull request fixes 4 alerts when merging 7bddf8d into 34ff1c3 - view on LGTM.com

fixed alerts:

  • 2 for Result of multiplication cast to wider type
  • 2 for Dereferenced variable may be null

Comment posted by LGTM.com

@dbwiddis dbwiddis merged commit 2f1b100 into oshi:master Jan 17, 2019
@dbwiddis dbwiddis deleted the perf-groups branch January 17, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants