Processor identifier to centralProcessor #964
Conversation
|
|
|
||
| /** | ||
| * Name, eg. Intel(R) Core(TM)2 Duo CPU T7300 @ 2.00GHz | ||
| * | ||
| * @return Processor name. | ||
| */ | ||
| String getName(); | ||
| @Deprecated String getName(); |
There was a problem hiding this comment.
While technically correct, for style purposes put in a newline after the @Deprecated. Also add a @deprecated annotation to the javadoc (note the lower case) with a comment replaced by {@link ProcessorIdentifier#getName()}
|
|
||
| /** | ||
| * Name, eg. Intel(R) Core(TM)2 Duo CPU T7300 @ 2.00GHz | ||
| * | ||
| * @return Processor name. | ||
| */ | ||
| String getName(); | ||
| @Deprecated String getName(); |
There was a problem hiding this comment.
These are valid, but for style purposes add a new line between the @Deprecated annotation and the get. You also need to add the (lowercase) @deprecated annotation in the Javadoc, pointing to the new location this information will be. Such as @deprecated Replaced by {@link ProcessorIdentifier#getName}
oshi-core/src/main/java/oshi/hardware/common/AbstractCentralProcessor.java
Show resolved
Hide resolved
|
Also this needs a CHANGELOG entry. |
Do I have to also import this library in CentralProcessor which is previously imported in abstractCentralProcessor |
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
============================================
+ Coverage 77.01% 77.09% +0.07%
Complexity 2 2
============================================
Files 23 23
Lines 1114 1148 +34
Branches 140 143 +3
============================================
+ Hits 858 885 +27
- Misses 198 202 +4
- Partials 58 61 +3
Continue to review full report at Codecov.
|
|
@dbwiddis I didn't add the issue name in the changelog. |
Move the ProcessorIdentifier inner class to the CentralProcessor class