Spec file and systemd packaging updates #381
Merged
+116
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slagle
commented
Jan 5, 2022
slagle
commented
- Move spec file into rpm dir
- Package systemd unit files
- Build locally with git ref
- Conditionally create builder user
- The spec file is moved outside the container-build dir and into its own rpm dir. The tools/build-rpms.sh script and Containerfile are updated to handle the move. - The .tox dir is excluded from the tarball generation during the rpm build as it can be quite large in size and is not needed for packaging. - The contrib/build dir is removed at the beginning of the tools/build-rpms.sh script as it may be left over from previous runs. Signed-off-by: James Slagle <jslagle@redhat.com>
slagle
force-pushed
the
directord-bootstrap
branch
3 times, most recently
from
53e20c2
to
4950ecd
Compare
Updates the spec file to package systemd unit files within directord-server and directord-client subpackages. The command to generate the systemd unit files is also updated to use the packaged files, which will be available under the data directory (sys.prefix + share/directord). Signed-off-by: James Slagle <jslagle@redhat.com>
When using rpm-build.sh, the package is now versioned with the git ref instead of the hardcoded release version. Signed-off-by: James Slagle <jslagle@redhat.com>
If the builder user already exists, allow the container build to continue. This can be a time saver for development purposes when re-using an existing container image as the base image for the build. Signed-off-by: James Slagle <jslagle@redhat.com>
slagle
force-pushed
the
directord-bootstrap
branch
from
4950ecd
to
5f46495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.