Windows improvements #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no setenv, nor unsetenv, but we can emulate both of them using putenv.
It signaled a non-existent condition type
First, look at TMP instead of TMPDIR on Windows. Second, it's not possible to unlink a file if someone has it open, unless you use CreateFileA/W and set FILE_SHARE_DELETE. Therefore, note that OPEN-TEMPORARY-FILE may return a pathname as a second value. If it does, the user is reponsible to delete that file. Third, modify WITH-TEMPORARY-FILE to unlink the file.
Involves some slight modifications of tests and completely disabling some tests.
Addittionally, mark all functions that depend on that as supported
It's present, just not always useful
On non-Windows platforms there is no need to change the current directory; we can just merge with *D-P-D* and absolutize. Additionally, specify that the target is merged with the link's directory. Otherwise, it's possible to inherit the name or type from link if it is unspecified in target, which is probably not what anyone wants.
Now that most things are implemented on windows as well, there's no need to keep separate files for the high-level interface.
|
@daewok merged, thanks! I've given you the commit bit, BTW. Feel free to push directly in the future, or to continue to send pull requests if you'd like a code review. Improvement ideas 1 and 2 seem very good, I agree. BTW, do you know about https://github.com/Lovesan/doors? There might be some intersection here. |
|
That's awesome, thanks! I did not know about doors (but love the name). If I keep digging into Windows stuff I'll definitely take a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of commits implements most of the missing high-level functionality on Windows. The only thing remaining unsupported is
user-info. Because of that, I also removed the split between osicat.lisp and osicat-basic.lisp (sorry for the diff noise that creates!).Much of the missing functionality required calling out to win32 APIs. Additionally, added a few useful win32
defcfuns that aren't used by the high level functionality, but are useful and mirror some of the POSIXdefcfuns that also aren't used by the high level API. Between theosicatandosicat-windowspackages, I'm now able to use cl-tar to create a tar file from a directory on Windows and even preserve things like sym and hard links!The only intentional non-Windows behavioral change is in
make-link. It originally changed the working directory to*d-p-d*, but that seemed bogus to me for several reasons. First, the current directory is a per-process resource, so it could lead to weird behavior in multi-threaded programs. Second, some implementations have#p""as the default*d-p-d*. So I instead calledmerge-pathnamesexplicitly instead of relying on the working directory.Some future directions for improvement: