update build plugins & fix new spotbugs findings

osiegmar · Nov 1, 2023 · 301ae13 · 301ae13
1 parent 54bb79e
commit 301ae13
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/buildSrc/build.gradle.kts b/buildSrc/build.gradle.kts
@@ -7,5 +7,5 @@ repositories {
 }
 
 dependencies {
-    implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:5.0.14")
+    implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:5.2.1")
 }
diff --git a/example/src/main/java/example/CsvReaderExample.java b/example/src/main/java/example/CsvReaderExample.java
@@ -1,6 +1,7 @@
 package example;
 
 import java.io.IOException;
+import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.Iterator;
@@ -74,7 +75,7 @@ private static void advancedConfiguration() {
 
     private static void file() throws IOException {
         final Path path = Files.createTempFile("fastcsv", ".csv");
-        Files.writeString(path, "foo,bar\n");
+        Files.writeString(path, "foo,bar\n", StandardCharsets.UTF_8);
 
         try (CsvReader csv = CsvReader.builder().build(path)) {
             csv.forEach(System.out::println);

diff --git a/lib/build.gradle.kts b/lib/build.gradle.kts
@@ -6,8 +6,8 @@ plugins {
     `maven-publish`
     signing
     jacoco
-    id("me.champeau.jmh") version "0.7.1"
-    id("info.solidsoft.pitest") version "1.9.11"
+    id("me.champeau.jmh") version "0.7.2"
+    id("info.solidsoft.pitest") version "1.15.0"
     id("ru.vyarus.animalsniffer") version "1.7.1"
     id("biz.aQute.bnd.builder") version "7.0.0"
 }

diff --git a/lib/src/test/java/de/siegmar/fastcsv/reader/CsvScannerTest.java b/lib/src/test/java/de/siegmar/fastcsv/reader/CsvScannerTest.java
@@ -9,6 +9,7 @@
 import java.nio.channels.Channels;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
+import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -71,7 +72,8 @@ void genericData(final String line, final List<String> attributes, final String
     static List<Arguments> genericData() throws IOException {
         final List<Arguments> list = new ArrayList<>();
 
-        final List<String> lines = Files.readAllLines(Paths.get("src/intTest/resources/scanner.txt"));
+        final Path file = Paths.get("src/intTest/resources/scanner.txt");
+        final List<String> lines = Files.readAllLines(file, StandardCharsets.UTF_8);
         int lineNo = 0;
         for (final String line : lines) {
             lineNo++;