Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary "throws IOException" in CsvParser.parse() #9

Closed
qtxo opened this issue Feb 25, 2018 · 4 comments
Closed

Unnecessary "throws IOException" in CsvParser.parse() #9

qtxo opened this issue Feb 25, 2018 · 4 comments
Milestone

Comments

@qtxo
Copy link

qtxo commented Feb 25, 2018

You can remove the throws because there is nothing that can throw the exception.

public CsvParser parse(final Reader reader) / * nothing happens without throws IOException */{
        return new CsvParser(Objects.requireNonNull(reader, "reader must not be null"),
            fieldSeparator, textDelimiter, containsHeader, skipEmptyRows,
            errorOnDifferentFieldCount);
    }
@osiegmar
Copy link
Owner

Thanks, I know. I will change that in a new major version, because this will break compatibility.

@qtxo
Copy link
Author

qtxo commented Feb 25, 2018

You can add a new method and deprecate this onw, no?

@osiegmar
Copy link
Owner

All the parse methods are overloaded. I'd like to keep it that way (without adding a new one with the same functionality but a different name). FastCSV 2.0 will simply have this changed...

@osiegmar osiegmar added this to the 2.0 milestone Nov 4, 2020
@osiegmar
Copy link
Owner

osiegmar commented Nov 4, 2020

Will be handled in 2.0 - see

public CsvReader build(final Reader reader) {

@osiegmar osiegmar closed this as completed Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants