remove unnecessary list allocs

oskardudycz · May 19, 2024 · 499277c · 499277c
1 parent 5706cbb
commit 499277c
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 9 deletions.
diff --git a/Core.Testing/TestWebApplicationFactory.cs b/Core.Testing/TestWebApplicationFactory.cs
@@ -42,7 +42,7 @@ protected override IHost CreateHost(IHostBuilder builder)
     }
 
     public void PublishedExternalEventsOfType<TEvent>() where TEvent : IExternalEvent =>
-        externalEventProducer.PublishedEvents.OfType<TEvent>().ToList().Should().NotBeEmpty();
+        externalEventProducer.PublishedEvents.OfType<TEvent>().Should().NotBeEmpty();
 
     public Task PublishInternalEvent<TEvent>(TEvent @event, CancellationToken ct = default) where TEvent : notnull =>
         PublishInternalEvent(

diff --git a/...tStoreDB/DataAnalytics/MarketBasketAnalytics/MarketBasketAnalysis/ProductRelationships.cs b/...tStoreDB/DataAnalytics/MarketBasketAnalytics/MarketBasketAnalysis/ProductRelationships.cs
@@ -27,7 +27,7 @@ CancellationToken ct
 
             var currentSummary = await getCurrentSummary(ToStreamId(@event.ProductId), ct)
                 ?? ProductRelationshipsCalculated.Default();
-            
+
             var relatedProducts = Expand(@event.RelatedProducts).ToList();
 
             foreach (var currentRel in currentSummary.Relationships)
@@ -52,7 +52,7 @@ CancellationToken ct
                 relatedProducts
                     .Select(relationship =>
                         new ProductRelationshipsInBaskets(relationship, 1)
-                    ).ToList()
+                    )
             );
 
             return currentSummary with { Relationships = result, BasketsCount = currentSummary.BasketsCount + 1 };

diff --git a/Workshops/BuildYourOwnEventStore/05-StreamAggregation/EventStore.cs b/Workshops/BuildYourOwnEventStore/05-StreamAggregation/EventStore.cs
@@ -76,8 +76,7 @@ FROM events
                 JsonConvert.DeserializeObject(
                     @event.data,
                     Type.GetType(@event.type, true)!
-                ))
-            .ToList();
+                ));
     }
 
     private void CreateStreamsTable()

diff --git a/Workshops/BuildYourOwnEventStore/06-TimeTraveling/EventStore.cs b/Workshops/BuildYourOwnEventStore/06-TimeTraveling/EventStore.cs
@@ -86,8 +86,7 @@ FROM events
                 JsonConvert.DeserializeObject(
                     @event.data,
                     Type.GetType(@event.type, true)!
-                ))
-            .ToList();
+                ));
     }
 
     private void CreateStreamsTable()

diff --git a/Workshops/BuildYourOwnEventStore/08-Snapshots/EventStore.cs b/Workshops/BuildYourOwnEventStore/08-Snapshots/EventStore.cs
@@ -108,8 +108,7 @@ FROM events
                 JsonConvert.DeserializeObject(
                     @event.data,
                     Type.GetType(@event.type, true)!
-                ))
-            .ToList();
+                ));
     }
 
     private void CreateStreamsTable()