Added more information to EventStoreDBSubscriptionToAll warning when …

…cannot deserialize
oskardudycz · May 16, 2024 · 5b02593 · 5b02593
1 parent 3b5be3c
commit 5b02593
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/Core.EventStoreDB/Subscriptions/EventStoreDBSubscriptionToAll.cs b/Core.EventStoreDB/Subscriptions/EventStoreDBSubscriptionToAll.cs
@@ -106,7 +106,8 @@ CancellationToken token
                 // then we might get events that are from other module and we might not be able to deserialize them.
                 // In that case it's safe to ignore deserialization error.
                 // You may add more sophisticated logic checking if it should be ignored or not.
-                logger.LogWarning("Couldn't deserialize event with id: {EventId}", resolvedEvent.Event.EventId);
+                logger.LogWarning("Couldn't deserialize event with {EventType} and id: {EventId}",
+                    resolvedEvent.Event.EventType, resolvedEvent.Event.EventId);
 
                 if (!subscriptionOptions.IgnoreDeserializationErrors)
                     throw new InvalidOperationException(

diff --git a/Sample/EventStoreDB/Simple/ECommerce.Core/Projections/EntityFrameworkProjection.cs b/Sample/EventStoreDB/Simple/ECommerce.Core/Projections/EntityFrameworkProjection.cs
@@ -24,8 +24,6 @@ public class EntityFrameworkProjectionBuilder<TView, TDbContext>(IServiceCollect
     where TView : class
     where TDbContext : DbContext
 {
-    public readonly IServiceCollection services = services;
-
     public EntityFrameworkProjectionBuilder<TView, TDbContext> AddOn<TEvent>(Func<EventEnvelope<TEvent>, TView> handler) where TEvent : notnull
     {
         services.AddSingleton(handler);