Used array initialiser instead of List constructor

oskardudycz · Apr 30, 2024 · 7cb33aa · 7cb33aa
1 parent 366aeae
commit 7cb33aa
Show file tree

Hide file tree

Showing 61 changed files with 131 additions and 128 deletions.
diff --git a/Core.EventStoreDB.Tests/Commands/EventStoreDBAsyncCommandBusTests.cs b/Core.EventStoreDB.Tests/Commands/EventStoreDBAsyncCommandBusTests.cs
@@ -19,7 +19,7 @@ namespace EventStoreDB.Integration.Tests.Commands;
 public class EventStoreDBAsyncCommandBusTests
 {
     private readonly EventStoreDBAsyncCommandBus martenAsyncCommandBus;
-    private readonly List<Guid> userIds = new();
+    private readonly List<Guid> userIds = [];
     private readonly EventListener eventListener = new();
     private readonly CancellationToken ct = new CancellationTokenSource().Token;
     private readonly EventStoreClient eventStoreClient;

diff --git a/Core.EventStoreDB/Events/EventStoreDBExtensions.cs b/Core.EventStoreDB/Events/EventStoreDBExtensions.cs
@@ -73,7 +73,7 @@ CancellationToken cancellationToken
         );
 
         if (await readResult.ReadState.ConfigureAwait(false) == ReadState.StreamNotFound)
-            return new List<object>();
+            return [];
 
         return await readResult
             .Select(@event => @event.Deserialize()!)

diff --git a/Core.WebApi/OptimisticConcurrency/OptimisticConcurrencyMiddleware.cs b/Core.WebApi/OptimisticConcurrency/OptimisticConcurrencyMiddleware.cs
@@ -13,9 +13,9 @@ public class OptimisticConcurrencyMiddleware
     private readonly RequestDelegate next;
 
     private readonly string[] SupportedMethods =
-    {
+    [
         HttpMethod.Post.Method, HttpMethod.Put.Method, HttpMethod.Delete.Method
-    };
+    ];
 
     public OptimisticConcurrencyMiddleware(
         RequestDelegate next

diff --git a/Core.WebApi/Swagger/MetadataOperationFilter.cs b/Core.WebApi/Swagger/MetadataOperationFilter.cs
@@ -6,9 +6,9 @@ namespace Core.WebApi.Swagger;
 public class MetadataOperationFilter: IOperationFilter
 {
     private static readonly string[] StateChangeMethods =
-    {
+    [
         HttpMethod.Post.Method, HttpMethod.Put.Method, HttpMethod.Delete.Method
-    };
+    ];
 
     public void Apply(OpenApiOperation operation, OperationFilterContext context)
     {

diff --git a/Core/Events/EventBus.cs b/Core/Events/EventBus.cs
@@ -75,7 +75,7 @@ private async Task Publish<TEvent>(EventEnvelope<TEvent> eventEnvelope, Cancella
     public Task Publish(IEventEnvelope eventEnvelope, CancellationToken ct)
     {
         return (Task)GetGenericPublishFor(eventEnvelope)
-            .Invoke(this, new object[] { eventEnvelope, ct })!;
+            .Invoke(this, [eventEnvelope, ct])!;
     }
 
     private static MethodInfo GetGenericPublishFor(IEventEnvelope @event) =>

diff --git a/Marten.Integration.Tests/Commands/MartenAsyncCommandBusTests.cs b/Marten.Integration.Tests/Commands/MartenAsyncCommandBusTests.cs
@@ -86,7 +86,7 @@ public override async Task InitializeAsync()
     }
 
     private MartenAsyncCommandBus martenAsyncCommandBus = default!;
-    private readonly List<Guid> userIds = new();
+    private readonly List<Guid> userIds = [];
     private readonly EventListener eventListener = new();
     private IProjectionCoordinator asyncDaemon = default!;
     private readonly CancellationToken ct = new CancellationTokenSource().Token;

diff --git a/.../AsyncProjections/SmartHome.Temperature/TemperatureMeasurements/TemparatureMeasurement.cs b/.../AsyncProjections/SmartHome.Temperature/TemperatureMeasurements/TemparatureMeasurement.cs
@@ -54,7 +54,7 @@ public void Apply(TemperatureMeasurementStarted @event)
     {
         Id = @event.MeasurementId;
         Started = @event.StartedAt;
-        Mesurements = new List<decimal>();
+        Mesurements = [];
     }
 
 

diff --git a/Sample/CRUDToCQRS/01-CRUD/ECommerce/Core/Repositories/CRUDRepository.cs b/Sample/CRUDToCQRS/01-CRUD/ECommerce/Core/Repositories/CRUDRepository.cs
@@ -45,7 +45,7 @@ public TEntity Delete(TEntity entity)
 
     public ValueTask<TEntity?> FindByIdAsync(Guid id, CancellationToken ct)
     {
-        return dbContext.Set<TEntity>().FindAsync(new object?[] { id }, ct);
+        return dbContext.Set<TEntity>().FindAsync([id], ct);
     }
 
     public Task SaveChangesAsync(CancellationToken ct)

diff --git a/Sample/CRUDToCQRS/02-CRUDWithCQRS/ECommerce/Core/Repositories/Repository.cs b/Sample/CRUDToCQRS/02-CRUDWithCQRS/ECommerce/Core/Repositories/Repository.cs
@@ -39,7 +39,7 @@ public void Delete(TEntity entity)
     public ValueTask<TEntity?> FindByIdAsync(Guid id, CancellationToken cancellationToken = default)
     {
         return dbContext.Set<TEntity>().FindAsync(
-            new object?[] { id },
+            [id],
             cancellationToken: cancellationToken
         );
     }

diff --git a/Sample/CRUDToCQRS/03-DomainGrouping/ECommerce.Domain/Core/Repositories/Repository.cs b/Sample/CRUDToCQRS/03-DomainGrouping/ECommerce.Domain/Core/Repositories/Repository.cs
@@ -40,7 +40,7 @@ public void Delete(TEntity entity)
     public ValueTask<TEntity?> FindByIdAsync(Guid id, CancellationToken cancellationToken = default)
     {
         return dbContext.Set<TEntity>().FindAsync(
-            new object?[] { id },
+            [id],
             cancellationToken: cancellationToken
         );
     }

diff --git a/Sample/CRUDToCQRS/04-SlimmedDomain/ECommerce.Domain/Core/Repositories/DbContextExtensions.cs b/Sample/CRUDToCQRS/04-SlimmedDomain/ECommerce.Domain/Core/Repositories/DbContextExtensions.cs
@@ -7,7 +7,7 @@ public static class DbContextExtensions
     public static ValueTask<TEntity?> FindById<TEntity>(this DbContext dbContext, Guid id, CancellationToken ct)
         where TEntity : class =>
         dbContext.Set<TEntity>().FindAsync(
-            new object?[] { id },
+            [id],
             cancellationToken: ct
         );
 

diff --git a/...le/CRUDToCQRS/05-ExplicitDomain/ECommerce.Domain/Core/Repositories/DbContextExtensions.cs b/...le/CRUDToCQRS/05-ExplicitDomain/ECommerce.Domain/Core/Repositories/DbContextExtensions.cs
@@ -7,7 +7,7 @@ public static class DbContextExtensions
     public static ValueTask<TEntity?> FindById<TEntity>(this DbContext dbContext, Guid id, CancellationToken ct)
         where TEntity : class =>
         dbContext.Set<TEntity>().FindAsync(
-            new object?[] { id },
+            [id],
             cancellationToken: ct
         );
 

diff --git a/Sample/CRUDToCQRS/06-SlicedDomain/ECommerce.Domain/Core/Repositories/DbContextExtensions.cs b/Sample/CRUDToCQRS/06-SlicedDomain/ECommerce.Domain/Core/Repositories/DbContextExtensions.cs
@@ -7,7 +7,7 @@ public static class DbContextExtensions
     public static ValueTask<TEntity?> FindById<TEntity>(this DbContext dbContext, Guid id, CancellationToken ct)
         where TEntity : class =>
         dbContext.Set<TEntity>().FindAsync(
-            new object?[] { id },
+            [id],
             cancellationToken: ct
         );
 

diff --git a/...e/CRUDToCQRS/07-FlattenedLayers/ECommerce.Domain/Core/Repositories/DbContextExtensions.cs b/...e/CRUDToCQRS/07-FlattenedLayers/ECommerce.Domain/Core/Repositories/DbContextExtensions.cs
@@ -7,7 +7,7 @@ public static class DbContextExtensions
     public static ValueTask<TEntity?> FindById<TEntity>(this DbContext dbContext, Guid id, CancellationToken ct)
         where TEntity : class =>
         dbContext.Set<TEntity>().FindAsync(
-            new object?[] { id },
+            [id],
             cancellationToken: ct
         );
 

diff --git a/...e/CRUDToCQRS/08-SlicedEndpoints/ECommerce.Domain/Core/Repositories/DbContextExtensions.cs b/...e/CRUDToCQRS/08-SlicedEndpoints/ECommerce.Domain/Core/Repositories/DbContextExtensions.cs
@@ -7,7 +7,7 @@ public static class DbContextExtensions
     public static ValueTask<TEntity?> FindById<TEntity>(this DbContext dbContext, Guid id, CancellationToken ct)
         where TEntity : class =>
         dbContext.Set<TEntity>().FindAsync(
-            new object?[] { id },
+            [id],
             cancellationToken: ct
         );
 

diff --git a/...e/CRUDToCQRS/09-MultipleModules/ECommerce.Domain/Core/Repositories/DbContextExtensions.cs b/...e/CRUDToCQRS/09-MultipleModules/ECommerce.Domain/Core/Repositories/DbContextExtensions.cs
@@ -7,7 +7,7 @@ public static class DbContextExtensions
     public static ValueTask<TEntity?> FindById<TEntity>(this DbContext dbContext, Guid id, CancellationToken ct)
         where TEntity : class =>
         dbContext.Set<TEntity>().FindAsync(
-            new object?[] { id },
+            [id],
             cancellationToken: ct
         );
 

diff --git a/Sample/ECommerce/Orders/Orders.Api.Tests/Orders/InitializingOrder/InitializeOrderTests.cs b/Sample/ECommerce/Orders/Orders.Api.Tests/Orders/InitializingOrder/InitializeOrderTests.cs
@@ -34,11 +34,11 @@ public InitializeOrderTests(TestWebApplicationFactory<Program> fixture)
 
     private readonly Guid ClientId = Guid.NewGuid();
 
-    private readonly List<PricedProductItemRequest> ProductItems = new()
-    {
+    private readonly List<PricedProductItemRequest> ProductItems =
+    [
         new PricedProductItemRequest { ProductId = Guid.NewGuid(), Quantity = 10, UnitPrice = 3 },
         new PricedProductItemRequest { ProductId = Guid.NewGuid(), Quantity = 3, UnitPrice = 7 }
-    };
+    ];
 
     private decimal TotalPrice => ProductItems.Sum(pi => pi.Quantity!.Value * pi.UnitPrice!.Value);
 }
diff --git a/Sample/ECommerce/Shipments/Shipments.Api.Tests/Packages/SendPackageTests.cs b/Sample/ECommerce/Shipments/Shipments.Api.Tests/Packages/SendPackageTests.cs
@@ -44,9 +44,9 @@ public SendPackageTests(TestWebApplicationFactory<Program> fixture)
 
     private readonly DateTime TimeBeforeSending = DateTime.UtcNow;
 
-    private readonly List<ProductItem> ProductItems = new()
-    {
+    private readonly List<ProductItem> ProductItems =
+    [
         new ProductItem { ProductId = Guid.NewGuid(), Quantity = 10 },
         new ProductItem { ProductId = Guid.NewGuid(), Quantity = 3 }
-    };
+    ];
 }
diff --git a/Sample/EventPipelines/EventPipelines.Tests/ClassesWithBuilderTest.cs b/Sample/EventPipelines/EventPipelines.Tests/ClassesWithBuilderTest.cs
@@ -24,10 +24,10 @@ string TenantName
 
     public class AdminStorage
     {
-        public static readonly string[] TenantNames = { "FB", "Google", "Twitter" };
+        public static readonly string[] TenantNames = ["FB", "Google", "Twitter"];
 
-        public List<AdminGrantedInTenant> AdminsInTenants = new();
-        public List<AdminAdded> GlobalAdmins = new();
+        public List<AdminGrantedInTenant> AdminsInTenants = [];
+        public List<AdminAdded> GlobalAdmins = [];
     }
 
     public class IsAdmin: IEventFilter<UserAdded>

diff --git a/Sample/EventPipelines/EventPipelines.Tests/ClassesWithIoCTest.cs b/Sample/EventPipelines/EventPipelines.Tests/ClassesWithIoCTest.cs
@@ -27,10 +27,10 @@ string TenantName
 
     public class AdminStorage
     {
-        public static readonly string[] TenantNames = { "FB", "Google", "Twitter" };
+        public static readonly string[] TenantNames = ["FB", "Google", "Twitter"];
 
-        public List<AdminGrantedInTenant> AdminsInTenants = new();
-        public List<AdminAdded> GlobalAdmins = new();
+        public List<AdminGrantedInTenant> AdminsInTenants = [];
+        public List<AdminAdded> GlobalAdmins = [];
     }
 
     public class IsAdmin: IEventFilter<UserAdded>

diff --git a/Sample/EventPipelines/EventPipelines.Tests/ClassesWithMediatRTest.cs b/Sample/EventPipelines/EventPipelines.Tests/ClassesWithMediatRTest.cs
@@ -27,10 +27,10 @@ string TenantName
 
     public class AdminStorage
     {
-        public static readonly string[] TenantNames = { "FB", "Google", "Twitter" };
+        public static readonly string[] TenantNames = ["FB", "Google", "Twitter"];
 
-        public List<AdminGrantedInTenant> AdminsInTenants = new();
-        public List<AdminAdded> GlobalAdmins = new();
+        public List<AdminGrantedInTenant> AdminsInTenants = [];
+        public List<AdminAdded> GlobalAdmins = [];
     }
 
     public class IsAdmin: IEventFilter<UserAdded>

diff --git a/Sample/EventPipelines/EventPipelines.Tests/PureFunctionsWithBuilderTest.cs b/Sample/EventPipelines/EventPipelines.Tests/PureFunctionsWithBuilderTest.cs
@@ -24,10 +24,10 @@ string TenantName
 
     public static class AdminPipeline
     {
-        public static readonly string[] TenantNames = { "FB", "Google", "Twitter" };
+        public static readonly string[] TenantNames = ["FB", "Google", "Twitter"];
 
-        public static List<AdminGrantedInTenant> AdminsInTenants = new();
-        public static List<AdminAdded> GlobalAdmins = new();
+        public static List<AdminGrantedInTenant> AdminsInTenants = [];
+        public static List<AdminAdded> GlobalAdmins = [];
 
         public static bool IsAdmin(UserAdded @event) =>
             @event.IsAdmin;

diff --git a/Sample/EventPipelines/EventPipelines.Tests/PureFunctionsWithIoCTest.cs b/Sample/EventPipelines/EventPipelines.Tests/PureFunctionsWithIoCTest.cs
@@ -25,10 +25,10 @@ string TenantName
 
     public static class AdminPipeline
     {
-        public static readonly string[] TenantNames = { "FB", "Google", "Twitter" };
+        public static readonly string[] TenantNames = ["FB", "Google", "Twitter"];
 
-        public static List<AdminGrantedInTenant> AdminsInTenants = new();
-        public static List<AdminAdded> GlobalAdmins = new();
+        public static List<AdminGrantedInTenant> AdminsInTenants = [];
+        public static List<AdminAdded> GlobalAdmins = [];
 
         public static bool IsAdmin(UserAdded @event) =>
             @event.IsAdmin;

diff --git a/Sample/EventPipelines/EventPipelines.Tests/PureFunctionsWithMediatRTest.cs b/Sample/EventPipelines/EventPipelines.Tests/PureFunctionsWithMediatRTest.cs
@@ -27,10 +27,10 @@ string TenantName
 
     public static class AdminPipeline
     {
-        public static readonly string[] TenantNames = { "FB", "Google", "Twitter" };
+        public static readonly string[] TenantNames = ["FB", "Google", "Twitter"];
 
-        public static List<AdminGrantedInTenant> AdminsInTenants = new();
-        public static List<AdminAdded> GlobalAdmins = new();
+        public static List<AdminGrantedInTenant> AdminsInTenants = [];
+        public static List<AdminAdded> GlobalAdmins = [];
 
         public static bool IsAdmin(UserAdded @event) =>
             @event.IsAdmin;

diff --git a/Sample/EventPipelines/EventPipelines/Builder.cs b/Sample/EventPipelines/EventPipelines/Builder.cs
@@ -2,7 +2,7 @@
 
 public class EventHandlersBuilder
 {
-    private readonly List<IEventHandler> eventHandlers = new();
+    private readonly List<IEventHandler> eventHandlers = [];
 
     private EventHandlersBuilder()
     {

diff --git a/Sample/EventStoreDB/Simple/ECommerce.Core/EventStoreDB/EventStoreDBExtensions.cs b/Sample/EventStoreDB/Simple/ECommerce.Core/EventStoreDB/EventStoreDBExtensions.cs
@@ -46,7 +46,7 @@ public static class EventStoreDBExtensions
         );
 
         if (await readResult.ReadState == ReadState.StreamNotFound)
-            return new List<object>();
+            return [];
 
         return await readResult
             .Select(@event => @event.Deserialize()!)

diff --git a/Sample/EventStoreDB/Simple/ECommerce.Core/Projections/EntityFrameworkProjection.cs b/Sample/EventStoreDB/Simple/ECommerce.Core/Projections/EntityFrameworkProjection.cs
@@ -127,7 +127,7 @@ public class UpdateProjection<TView, TEvent, TDbContext>: IEventHandler<EventEnv
     public async Task Handle(EventEnvelope<TEvent> eventEnvelope, CancellationToken ct)
     {
         var viewId = getViewId(eventEnvelope.Data);
-        var view = await dbContext.FindAsync<TView>(new [] {viewId}, ct);
+        var view = await dbContext.FindAsync<TView>([viewId], ct);
 
         if (view == null)
             throw new InvalidOperationException($"{typeof(TView).Name} with id {viewId} wasn't found");

diff --git a/Sample/EventStoreDB/Simple/ECommerce/ShoppingCarts/ProductItems/ProductItemsList.cs b/Sample/EventStoreDB/Simple/ECommerce/ShoppingCarts/ProductItems/ProductItemsList.cs
@@ -43,7 +43,7 @@ public ProductItemsList Remove(PricedProductItem productItem)
         );
 
     public static ProductItemsList Empty() =>
-        new(new List<PricedProductItem>());
+        new([]);
 
     public override string ToString() =>
         $"[{string.Join(", ", items.Select(pi => pi.ToString()))}]";

diff --git a/Sample/EventsVersioning/EventsVersioning.Tests/Transformations/StreamTransformations.cs b/Sample/EventsVersioning/EventsVersioning.Tests/Transformations/StreamTransformations.cs
@@ -33,7 +33,7 @@ List<EventData> events
                 .CorrelationId;
 
         var i = 1;
-        List<EventData> productItemsAdded = new();
+        List<EventData> productItemsAdded = [];
 
         while (i < events.Count)
         {
@@ -58,9 +58,10 @@ List<EventData> events
             productItemsAdded
         );
 
-        return new List<EventData>(
-            new[] { mergedEvent }.Union(events.Skip(i))
-        );
+        return
+        [
+            ..new[] { mergedEvent }.Union(events.Skip(i))
+        ];
     }
 
     private EventData ToShoppingCartInitializedWithProducts(
@@ -72,8 +73,9 @@ List<EventData> productItemsAdded
 
         var newEvent = new ShoppingCartInitializedWithProducts(
             shoppingCartInitializedJson.GetProperty("ShoppingCartId").GetGuid(),
-            shoppingCartInitializedJson.GetProperty("ClientId").GetGuid(), new List<V1.PricedProductItem>(
-                productItemsAdded.Select(pi =>
+            shoppingCartInitializedJson.GetProperty("ClientId").GetGuid(), [
+
+                ..productItemsAdded.Select(pi =>
                 {
                     var pricedProductItem = JsonDocument.Parse(pi.Data).RootElement.GetProperty("ProductItem");
                     var productItem = pricedProductItem.GetProperty("ProductItem");
@@ -83,7 +85,8 @@ List<EventData> productItemsAdded
                             productItem.GetProperty("Quantity").GetInt32()),
                         pricedProductItem.GetProperty("UnitPrice").GetDecimal());
                 })
-            )
+
+            ]
         );
 
         return new EventData("shopping_cart_initialized_v2", JsonSerializer.Serialize(newEvent),
@@ -92,7 +95,7 @@ List<EventData> productItemsAdded
 
     public class StreamTransformations
     {
-        private readonly List<Func<List<EventData>, List<EventData>>> jsonTransformations = new();
+        private readonly List<Func<List<EventData>, List<EventData>>> jsonTransformations = [];
 
         public List<EventData> Transform(List<EventData> events)
         {

diff --git a/...pdesk.Wolverine/Helpdesk.Api/Incidents/GettingCustomerIncidentsSummary/IncidentSummary.cs b/...pdesk.Wolverine/Helpdesk.Api/Incidents/GettingCustomerIncidentsSummary/IncidentSummary.cs
@@ -49,10 +49,10 @@ public void Apply(IncidentClosed closed, CustomerIncidentsSummary current)
 public class CustomerIncidentsSummaryGrouper: IAggregateGrouper<Guid>
 {
     private readonly Type[] eventTypes =
-    {
+    [
         typeof(IncidentResolved), typeof(ResolutionAcknowledgedByCustomer),
         typeof(IncidentClosed)
-    };
+    ];
 
     public async Task Group(IQuerySession session, IEnumerable<IEvent> events, ITenantSliceGroup<Guid> grouping)
     {

diff --git a/Sample/Helpdesk/Helpdesk.Api.Tests/Incidents/RecordAgentResponseToIncidentTests.cs b/Sample/Helpdesk/Helpdesk.Api.Tests/Incidents/RecordAgentResponseToIncidentTests.cs
@@ -31,10 +31,10 @@ await API
                 RESPONSE_BODY(
                     API.Incident with
                     {
-                        Notes = new[]
-                        {
+                        Notes =
+                        [
                             new IncidentNote(IncidentNoteType.FromAgent, agentId, content, visibleToCustomer)
-                        },
+                        ],
                         Version = 2
                     }
                 )

diff --git a/Sample/Helpdesk/Helpdesk.Api.Tests/Incidents/RecordCustomerResponseToIncidentTests.cs b/Sample/Helpdesk/Helpdesk.Api.Tests/Incidents/RecordCustomerResponseToIncidentTests.cs
@@ -31,7 +31,7 @@ await API
                     API.Incident with
                     {
                         Notes =
-                        new[] { new IncidentNote(IncidentNoteType.FromCustomer, customerId, content, true) },
+                        [new IncidentNote(IncidentNoteType.FromCustomer, customerId, content, true)],
                         Version = 2
                     }
                 )