Updates to projections tests in Introduction to Event Sourcing workshop #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskardudycz
force-pushed
the
workshop/introduction-to-event-sourcing
branch
from
fc71a3d
to
a2f9e21
Compare
bartelink
reviewed
Mar 15, 2022
| if (!storage.ContainsKey(id)) | ||
| storage.Add(id, obj); | ||
| else | ||
| storage[id] = obj; |
There was a problem hiding this comment.
idiomatic impl for upsert given the Dictionary API is to do only this line, blindly
(the ContainsKey is waste)
(aside: ContainsKey is not present in the ConcurrentDictionary API either for the more obvious reason of it being prone to race conditions)
(In F#, Map.add has this upsert semantic)
bartelink
reviewed
Mar 15, 2022
| @@ -12,6 +12,12 @@ public class Database | |||
| var validFrom = DateTime.UtcNow.AddMilliseconds(random.Next(250, 1000)); | |||
|
|
|||
| storage.Add(id, new DataWrapper(obj, validFrom)); | |||
There was a problem hiding this comment.
I guess you meant to remove this (but again should be L20 only)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database.Storemethod to do upsert instead of add.