Marker size workaround for backwards compatibility'ish #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-2.7.0 Oskari marker sizes were always given as values between 1-5 and calculated to actual size with
size * 10 + 40. In 2.7.0 the size for markers changed to actual pixel values WHEN using external graphic instead of the built-in shapes (since the size is easier to know for developer experience when using external graphics). Since there are RPC-based apps using the small values with external graphics those markers are too tiny to see. Any "real" value for marker size is most probably at least 10 with the new API. So this is a hack' ish kind of workaround to restore outdated RPC-based apps to have usable markers while still maintaining the new API.Kinda weird and wonky, but in practice this should fix any compatibility issues that people might have.