Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapmodule cleaning #2163

Merged
merged 16 commits into from
Mar 9, 2023
Merged

Mapmodule cleaning #2163

merged 16 commits into from
Mar 9, 2023

Conversation

ZakarFin
Copy link
Member

@ZakarFin ZakarFin commented Mar 8, 2023

  • Remove references to toolstyle
  • Moved abstract plugin files from mapmodule root to plugin folder where some of the other abstract plugin files already were located
  • Move functionality to helper-files to make the module more readable (crosshair, plugins handling, theme)

@ZakarFin
Deprecated getToolStyle() returns null always -> return dark always
3604422
@ZakarFin
getTheme() returns dark always -> return light
b8c5358
@ZakarFin
Remove toolStyle related code as it always defaults 'dark' and cant b…
78a0069 
…e configured
@ZakarFin
Remove unused getThemeColours()
6d7647d
@ZakarFin
Remove unused getTheme()/getReverseTheme() - use getMapTheme() instead
b0c584f
@ZakarFin
Remove unused getToolStyleFromMapModule()/font - use getMapTheme() in…
be6e86a 
…stead
@ZakarFin
Remove unused changeCssClasses
f1c3fd6
@ZakarFin
Remove unused functions from BasicMapModulePlugin
a5877e8
@ZakarFin
Move abstract plugins to plugin folder
5eddfaa
@ZakarFin
Migrate mapmodule functions to util/helpers
a146058
@ZakarFin
We only need data when starting publisher
0c614d5
@ZakarFin
Add names used by mapmodule
0ec1fad
@ZakarFin
Fix comment, use getter
7c2d887
@ZakarFin
Cleanup maprotator
8f9376d
@ZakarFin
Make ESlint happy
efaebed
@ZakarFin
Fixed tests
1b1839b
@ZakarFin ZakarFin marked this pull request as ready for review March 9, 2023 11:39
@ZakarFin ZakarFin added this to the 2.11.0 milestone Mar 9, 2023
@ZakarFin ZakarFin merged commit 214c7b6 into oskariorg:develop Mar 9, 2023
@ZakarFin ZakarFin deleted the mapmodule-cleaning branch March 9, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.0
1 participant
@ZakarFin