Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for SearchPlugin #2166

Merged
merged 28 commits into from
Mar 13, 2023
Merged

Conversation

ZakarFin
Copy link
Member

  • Make the search plugin larger when it's showing the search field.
  • Make it less transparent when the field has focus (so text on map doesn't show through)
  • Add options how to show results by channel when there are multiple channels queried.
  • Triggers searches for each channel separately so slower channels don't block showing results from faster channels

The question mark icon shows channel description in tooltip when available (mostly for WFS search channels for now).

TODO: for replacing current search on geoportal with this:

  • autocomplete when available
  • add handling for Search.AddSearchResultActionRequest and Search.RemoveSearchResultActionRequest

Using defaults:

{
    id: 'Oskari.mapframework.bundle.mapmodule.plugin.SearchPlugin',
    config: {
       // allowOptions: true,
       // columns: ['name', 'region', 'type'],
       // useInfobox: true
    }
 }

Single search channel (shown in generic search results accordion)

image

Multiple search channels (shown as accordions per channel, named after channel)

image

Using configuration to use infobox instead of marker, selecting columns to show on result table and allowing options to be shown for user

{
    id: 'Oskari.mapframework.bundle.mapmodule.plugin.SearchPlugin',
    config: {
       allowOptions: true,
       columns: ['selected', 'name', 'type'],
       useInfobox: true
    }
 }

image

Using the theme from Paikkatietoikkuna:

Single channel

image

Multiple channels

image

@ZakarFin ZakarFin marked this pull request as ready for review March 13, 2023 16:29
@ZakarFin ZakarFin added this to the 2.11.0 milestone Mar 13, 2023
@ZakarFin ZakarFin merged commit 959d1e7 into oskariorg:develop Mar 13, 2023
@ZakarFin ZakarFin deleted the results-by-channel branch March 13, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant