Admin-layereditor json fields POC #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
…into admin-layereditor-json-fields
ZakarFin
reviewed
Jan 11, 2024
| @@ -113,6 +117,12 @@ Oskari.registerLocalization( | |||
| "globalWithStyles": "Tasolle on määritetty vain yksi yleinen oletuskarttaselite, vaikka sillä olisi rajapintapalvelusta useita tyylejä käytettävissä. Poista oletuskarttaselite ja määritä mahdolliset tyylikohtaiset karttaselitteet." | |||
| } | |||
| }, | |||
| "jsonFields": { | |||
There was a problem hiding this comment.
Do we have these translations for swedish?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tab for JSON fields (options, capabilities, attributes, params). Every json have text area to review content. Tools for adding key value pairs to json and deleting key from json. Value is parsed so also Object or Array can be added. So everything but whole json should be added or deleted.
These could be removed:
'Show GetCapabilities response' opens xml to new tab so it's little dummy to change tab to compare xml and json
If attributes is removed, setting extra values inside data (e.g. noDataValue) might need ui component. or other solution
Also tempJSON handling can be removed from handler. BTW: not sure why there is so many setters. I often use common(key, value) setter instead of many named(value).
I think that named keys in WFSLayerOptions.java and WFSLayerAttributes.java could have own inputs in layereditor
maxFeatures, namespaceURL, noDataValue, commonIdlabelProperty-> StyleEditor text tab?