-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use wp-rest-jsonapi-serializer #23
Comments
I'm not sure if we want to add more dependencies on the server though. Especially for themes It might be a good idea to keep the number of dependent plugins low. |
If Taras's implementation of the serializer is more robust ~ than it may make sense to offload that responsibility, but at the core / that's mostly what this addon is, right? Maybe we should get his input and long-term intentions. He's an wonderful fella, but he may have only been temporarily excited for that one week.
If The serializer focuses and sticks to the Ember style idiomatic approach / than maybe it should stand on it's own, but otherwise ~ it may be better to combine forces / or we'll just have two competing addons with limited attention. In general I could see this addon in many parts. I may not need to write, or use categories - for example. It would be nice to keep it as light as possible with a config or something to decide what is actually incorporated / or to have the addon broken up. I expect that not too far in the future, there will be many many more opinions - but as it is, we seem to be on an island for the time being. |
Customizing Ember Data serializers is the right solution when you don't have control over the backend. When people create WordPress sites, then have access to the WP admin, so they can install whatever plugins necessary. It's also important to note that I created www.embermeetup.com is a good example of this setup. I use total 0 themes and 15 plugins on the entire site. Here is the list of plugins: -Admin Columns Most of these plugins provide low level customizations to WordPress.
WordPress for me is just using something that I know to help me support a hobby(EmberMeetup.com). I'd be happy to support anyone is evolving
I would suggest like to combine efforts. Possibly, even create
The right way to do this in Emberland is to wait for treesharking to finalized. With tree shaking, you'll be able to install an addon and use what you need and everything that you don't use will be shaken out of your project. So, I'd suggest that we don't worry about this right now.
If we start to tell people about it, then we might be able to attract more people to this project. In that case, they'll likely be a lot more people's opinions. This will be great because it'll give us real use cases for this code base. |
For my uses, I just create an Ember app and consume the API for brochure like sites. So, I also don't see how a WordPress theme would really be involved at all. You can't use the PHP widgets, so we just recreate those sorts of things with components. I use a few plugins like Admin Columns, Advanced Custom Fields, Custom Post Type UI, and Adminimize to make the Admin nice ~ and then I leave that to the client to fill out, while I build the front-end. I like it, for one - because I'm used to the admin and the clients are... that being said, the Admin (actually clicking from post to post to page etc.) is the most time consuming part of my development process. I keep hearing whispers about some Ember CMS that's supposed to happen. I know that Ghost was made with ember. If an Ember CMS that is ember-speed arrives, I'll jump to that train right away. Either way, there are a lot of businesses with a lot of data tied up in MySQL and WordPress, so I'm sure many people will be wanting to use this soon. Good points across the board from Taras |
@sheriffderek you'll like how Pods integrates with |
I think Django does something with it's admin - where it just builds the UI for the admin pages based on the API. It would be fun if there was an Advanced Custom Fields type situation for post-types/ resources and the associated fields... that was as simple as writing some JSON / but someone would have to stand to make $$$ to spend that time. In many cases, Its proven faster to just type the blog post in a template than to use WP.
RE: pods, I'm kinda weary of them with the new RFC ~ kinda waiting to see where things fall ~ but if you say it's a cool integration / I'll take your word for it! : ) |
@sheriffderek oh, I'm referring to Pods Framework It allows to define custom post type, fields and relationships. |
That sounds really great. I hadn't used that before / and I was having some
On Wed, Aug 10, 2016 at 4:37 PM, Taras Mankovski notifications@github.com
|
@taras Thinking about
I'm really looking forward to more crossover between them Ember and WordPress communities as I think they may be a very powerful combination when used together. Thanks everyone for your contributions. |
@daltonrooney you might want to checkout https://github.com/EmberMeetup/website it's a complete Ember app with WordPress as backend.
Agree. I created it as a solution to my needs. I needed something that would support relationships. From what I know, WP doesn't provide any kind of built in relationships setup.
I'm totally open to this.
I didnt know about this field or how it works. I'll need to look into it. Is it post type specific?
Yes, it's an all in solution at the moment.
Using query params with Ember Data would be awkward. A better solution would be to activate wp-rest-jsonapi-serializer when JSONAPI content type is detected in the header.
Agree. Are you interested in helping me evolve |
It looks like we can do a lot more with metadata now than was possible few years ago according to https://make.wordpress.org/core/2016/05/03/a-data-schema-for-meta/ We should take this conversation to wp-rest-jsonapi-serializer issue. See you there. |
Closing until/if something happens in the other repo :) |
With the help of @EmberSherpa's https://github.com/EmberSherpa/wp-rest-jsonapi-serializer we can potentially eliminate the need of most, if not all, of the serializer in this repo. Which is nice.
The text was updated successfully, but these errors were encountered: