more models and namespacing #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow this looks great, thank you for sharing. Let me just review it and we'll get this released asap! |
Bugfix/dummy app model names
Feature/mirage
Feature/mirage
|
Released as 0.2.0 Thanks a lot @gibso |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to use the addon in our ember app. This ember app is pretty large and complex, so i needed to add the namespaces in order to prevent model-name confusion.
Furthermore i added a few more models, like
user,attachmentandcomment, so you are able to load e.g. the posts comments.Overall i refactored a few things, like the
renderedobject key handling. I added an Ember-Transform to handle this in the model class.i hope these changes are useful to some other people.