Fix/targets #108
Merged
Fix/targets #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SamuelRott thoughts? This overlaps a bit with your new |
oskarrough
commented
Aug 20, 2020
| @@ -54,7 +54,7 @@ export const cards = [ | |||
| energy: 1, | |||
| damage: 5, | |||
| block: 5, | |||
| target: 'self and enemy', | |||
There was a problem hiding this comment.
this wasn't even implemented
oskarrough
commented
Aug 20, 2020
oskarrough
commented
Aug 20, 2020
public/ui/dragdrop.js
Outdated
| } | ||
|
|
||
| onAdd(cardElement.dataset.id, target, cardElement) |
There was a problem hiding this comment.
rename onAdd to afterRelease?
|
Hello, I dont think this overlap the conditions logic. They both concern different part of the game and rely on different logic. For the long run I would say that card.target is not going to be enough. We are going to need card.allowedTarget = []. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All cards have a
targetproperty that specifies which targets the card can be played at. Allowed ones are currentlyplayer,enemyandall enemies.Before this PR, it wasn't really enforced e.g. a "Strike" card with
target: enemycould also be played on yourself, the player.This PR changes that and makes sure the
card.targetis respected.If we later want to allow attacking yourself, we can now do that in a cleaner way by creating a new target
player and enemiesor something like that. But that's for later, at least now it's "clean".Closes #104 , fixes #106.