Add animation to the cards in hand after playing a card #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarrough
added a commit
that referenced
this pull request
Aug 27, 2022
Add animation to the cards in hand after playing a card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: you have 5 cards in hand. You play one. The flexbox "hand" now re-renders and the items jump into the new position. Looks sad.
This relies on the new (fantastic?!) "Flip" plugin from GSAP. But as the script is not released yet, I haven't included the dependencies in this PR yet. Keeping it ready for when the script is released by GSAP..
Closes #118