Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dungeon & jsdocs everywhere #200

Merged
merged 7 commits into from
Jul 23, 2023
Merged

Refactor dungeon & jsdocs everywhere #200

merged 7 commits into from
Jul 23, 2023

Conversation

oskarrough
Copy link
Owner

@oskarrough oskarrough commented Jul 23, 2023 •
edited

These are the concepts that concern the "map":

  • dungeon (wraps it all together and makes it navigatable)
  • graph (a 2D map)
  • path (a list of y/x moves through the nodes, from top to bottom)
  • floors (a row of positions on the map)
  • nodes (a position on the map)
  • rooms (where monsters live)
  • monsters (what you fight)
  • map (the ui)

This PR moves the files and methods a bit around. And made a bit of the generatePaths logic nicer.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 23, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 45228a9
Status: ✅  Deploy successful!
Preview URL: https://a7de37e8.slaytheweb.pages.dev
Branch Preview URL: https://feat-refactor-dungeon.slaytheweb.pages.dev

View logs

@oskarrough oskarrough marked this pull request as ready for review July 23, 2023 13:01
@oskarrough oskarrough changed the title Refactor dungeon Refactor dungeon & jsdocs everywhere Jul 23, 2023
@oskarrough oskarrough merged commit d761bc2 into main Jul 23, 2023
3 checks passed
@oskarrough oskarrough deleted the feat/refactor-dungeon branch September 14, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@oskarrough