Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cards into separate files #204

Merged
merged 4 commits into from
Sep 17, 2023
Merged

Move cards into separate files #204

merged 4 commits into from
Sep 17, 2023

Conversation

oskarrough
Copy link
Owner

Each card now has its own file and must follow provide two exports:

export default { ... card }
export const upgrade = (card) => card

This has the benefit that cards no longer have a upgrade method on the card object itself, which was giving trouble when serializing game state.

Closes #185

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 638cdf6
Status: ✅  Deploy successful!
Preview URL: https://70dbcf4b.slaytheweb.pages.dev
Branch Preview URL: https://feat-card-upgrade.slaytheweb.pages.dev

View logs

@oskarrough oskarrough merged commit 0bd6a3a into main Sep 17, 2023
3 checks passed
@oskarrough oskarrough deleted the feat/card-upgrade branch September 30, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split cards into multiple files
1 participant