Dungeon #26
Merged
Dungeon #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR now…
|
|
Let's see if we can make it nicer before merging. Time to self-review. |
oskarrough
commented
Mar 4, 2020
| import {uuid} from './utils.js' | ||
|
|
||
| // A dungeon is where the adventure starts. It has a path of rooms, you know where you are and you can continue to the next room. | ||
| export default function Dungeon(props) { |
There was a problem hiding this comment.
syntax is not so nice with all the this. can we do better?
oskarrough
added a commit
that referenced
this pull request
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there is one monster to fight and it is hardcoded as
state.monster. Instead of this, I want to introduce the concepts from Slay The Spire.You enter a dungeon. Each dungeon has a randomly generated path of encounters. There are different encounters like
battle,campfireandshop. Although I think we ignore shop for now.Is
battlethe right word?This also means that creating and setting a dungeon should be introduced as a required step when when starting a new game.