Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/targets #38

Merged
merged 4 commits into from
Mar 17, 2020
Merged

Feat/targets #38

merged 4 commits into from
Mar 17, 2020

Conversation

oskarrough
Copy link
Owner

Targets are complicated. This isn't perfect, but it does seem to work for now.

  • Cards that target all enemies will now properly apply to all, instead of the actual enemy where you dropped the card
  • Refactored getMonster -> getTargets

Closes #37

if (card.damage) {
// This should be refactored, but when you play an attack card that targets all enemies,
// we prioritize this over the actual enemy where you dropped the card.
const newTarget = card.target === 'all enemies' ? card.target : target
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oskarrough oskarrough merged commit 8234261 into master Mar 17, 2020
oskarrough added a commit that referenced this pull request Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify targets
1 participant