Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test and logic for rewarding BUT new bug with unloaded images #69

Merged
merged 12 commits into from
Apr 19, 2020
Merged

test and logic for rewarding BUT new bug with unloaded images #69

merged 12 commits into from
Apr 19, 2020

Conversation

GregVes
Copy link
Collaborator

@GregVes GregVes commented Apr 10, 2020 •
edited

I wrote a test for rewarding.

Regarding implementation

  • ui component displays 3 random cards.
  • OnClick on any card, it triggers handlePlayerReward in that dispatches a rewardPlayer action.

BUT all of sudden, I discovered that cards are not displayed anymore in the UI!*

  • solved! Forgot to pass around the state at a point.

@GregVes GregVes requested a review from oskarrough April 10, 2020 09:42
GregVes
GregVes commented Apr 10, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
GregVes
GregVes commented Apr 10, 2020
View reviewed changes
public/ui/app.js Outdated Show resolved Hide resolved
GregVes
GregVes commented Apr 10, 2020
View reviewed changes
tests/game.js Show resolved Hide resolved
GregVes
GregVes commented Apr 10, 2020
View reviewed changes
public/ui/cards.js Outdated Show resolved Hide resolved
GregVes
GregVes commented Apr 10, 2020
View reviewed changes
public/game/actions.js Outdated Show resolved Hide resolved
oskarrough
oskarrough requested changes Apr 10, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
public/game/actions.js Outdated Show resolved Hide resolved
public/game/cards.js Outdated
res.push(card)
}
return res
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an idea for the future (not now): we could group cards into different groups like "common cards" and "rare cards". The further down the dungeon you are, the higher the chance for finding a rare card!

public/ui/app.js Outdated Show resolved Hide resolved
tests/dungeon.js Show resolved Hide resolved
tests/game.js Outdated Show resolved Hide resolved
oskarrough
oskarrough reviewed Apr 10, 2020
View reviewed changes
public/ui/app.js Outdated Show resolved Hide resolved
oskarrough
oskarrough reviewed Apr 10, 2020
View reviewed changes
public/ui/index.css Outdated Show resolved Hide resolved
@oskarrough oskarrough merged commit e2e643c into master Apr 19, 2020
@oskarrough oskarrough mentioned this pull request Apr 19, 2020
Closed
oskarrough added a commit that referenced this pull request Aug 27, 2022
@oskarrough
Merge pull request #69 from oskarrough/feature/rewards
7046739 
test and logic for rewarding BUT new bug with unloaded images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarrough oskarrough oskarrough requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GregVes @oskarrough