Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(copernicus): Collect weather data from Copernicus API #3

Merged
merged 16 commits into from
Nov 23, 2022

Conversation

luabida
Copy link
Contributor

@luabida luabida commented Oct 18, 2022

Implement celery task that collects weather data from https://cds.climate.copernicus.eu/cdsapp#!/dataset/reanalysis-era5-single-levels for every city in Brazil. Upload data to sql database.

@esloch esloch assigned esloch and luabida and unassigned esloch Oct 22, 2022
@esloch esloch self-requested a review October 22, 2022 16:10
Copy link
Collaborator

@esloch esloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@esloch
Copy link
Collaborator

esloch commented Oct 22, 2022

@luabida, I think it can be merged and open a PR to add other features or improvements when needed.

@app.task
def reanalysis_insert_into_db(df: pd.DataFrame):

df.to_sql(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataFrame is being store without upsert, would you think upsert is needed to avoid duplicates?

@luabida luabida requested a review from esloch November 11, 2022 17:03
Copy link
Collaborator

@esloch esloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@esloch esloch merged commit 991d1ec into osl-incubator:main Nov 23, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@luabida luabida deleted the move-cds-weather branch January 27, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants