Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a new key in the root of the config file for services #110

Merged
merged 19 commits into from
Jan 25, 2024

Conversation

joel5vega
Copy link
Contributor

Pull Request description

How to test these changes

sugar build --verbose --config-file tests/containers/.services.sugar.yaml

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

@joel5vega joel5vega changed the title [Feature] 61 [Feature] SPEC: Add a new key in the root of the config file for services Jan 15, 2024
@xmnlab xmnlab changed the title [Feature] SPEC: Add a new key in the root of the config file for services feat: Add a new key in the root of the config file for services Jan 18, 2024
@xmnlab
Copy link
Contributor

xmnlab commented Jan 18, 2024

@joel5vega please rebase your branch on top of the upstream main.

now sugar.py was renamed to core.py

@joel5vega
Copy link
Contributor Author

@xmnlab can you check if newest push solve the problem?
image

@xmnlab
Copy link
Contributor

xmnlab commented Jan 20, 2024

Screenshot_20240119-231518_GitHub.jpg

It still has merge conflicts

Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for working on that @joel5vega

@xmnlab xmnlab merged commit 7e6eabc into osl-incubator:main Jan 25, 2024
8 checks passed
Copy link

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants