Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment without rollup #16

Merged
merged 3 commits into from Jan 8, 2022
Merged

Experiment without rollup #16

merged 3 commits into from Jan 8, 2022

Conversation

alberthan1
Copy link
Contributor

Refactor:

  • renamed functions/variables to be more semantic
  • removed extraneous functions
  • condensed rollup to stop bundling contentScript and no longer injected into banner and footer

@aramkrakirian @ErickMaese @SamVanTassel @trevleung

aramkrakirian
aramkrakirian approved these changes Jan 8, 2022
View reviewed changes
Copy link
Contributor

@aramkrakirian aramkrakirian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aramkrakirian aramkrakirian merged commit ff677e5 into dev Jan 8, 2022
@alberthan1 alberthan1 deleted the experiment_without_rollup branch January 10, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramkrakirian aramkrakirian aramkrakirian approved these changes

@trevleung trevleung trevleung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alberthan1 @aramkrakirian @trevleung