Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: testing instructions #33

Closed
iuioiua opened this issue Nov 28, 2022 · 6 comments
Closed

suggestion: testing instructions #33

iuioiua opened this issue Nov 28, 2022 · 6 comments
Assignees

Comments

@iuioiua
Copy link

iuioiua commented Nov 28, 2022

Hi team, I'd like to contribute to this great module. However, there aren't any testing instructions. Is it possible to have this added so contributors can do so?

@iuioiua
Copy link
Author

iuioiua commented Dec 4, 2022

Gently pinging

@iuioiua
Copy link
Author

iuioiua commented Jan 14, 2023

I am gently pinging once more. I'd love to help make this repo better! 🙂

CC @cdschexnide and @mdwatson988

@cdschexnide
Copy link
Contributor

Hi @iuioiua. Sorry for the delayed response. I started a new job in October last year and we use GitLab so I'm rarely on GitHub anymore. I believe if you fork and clone the repo, you can locally make whatever changes you'd like to add. Then once you submit the pull request and one of us approves it, you'd be added as a contributor.

@iuioiua
Copy link
Author

iuioiua commented Jan 20, 2023

Great! Thank you 🙏🏾

However, I was more referring to testing. If I make a change what test can I run to ensure I haven't broken anything?

@cdschexnide
Copy link
Contributor

This is the test file: https://github.com/oslabs-beta/Deno-Redlock/blob/main/src/single.test.ts

Running this test file in the terminal will verify that your additions do not interfere with proper lock functionality.

@iuioiua
Copy link
Author

iuioiua commented Feb 1, 2023

Ah, I didn't realise there was a src/single.test.ts. I was using src/testing/single.test.ts. Thanks!

@iuioiua iuioiua closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants