Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement download button #105

Merged
merged 5 commits into from Oct 13, 2022
Merged

Implement download button #105

merged 5 commits into from Oct 13, 2022

Conversation

BrianHao
Copy link
Contributor

This PR:

  • Implements download file button on Clipboard page
  • Updates favicon
  • Updates logo
  • Updates logo banner on README
  • Modifies Webpack & server.ts to build bundle.js to /dist without console error

Copy link
Collaborator

@mlamchamkee mlamchamkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete client/.DS_Store

@@ -2,6 +2,7 @@ import hljs from 'highlight.js/lib/common';
import React, { ChangeEvent, useEffect } from 'react';
import { useNavigate, useParams } from 'react-router-dom';

import DownloadIcon from '@mui/icons-material/Download';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort your imports

@@ -33,13 +33,18 @@ app.use('/auth', authRoutes);
app.use('/api/tests', testsRoutes);
app.use('/api/project', projectRoutes);
app.use('/api/clipboard', clipboardRoutes);
app.use('/dist', express.static(path.join(__dirname, '../dist')));
// app.use('/dist', express.static(path.join(__dirname, '../dist')));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we deleted commented line?

@@ -14,7 +15,7 @@
</head>
<body>
<div id="root"></div>
<script src="dist/bundle.js"></script>
<!-- <script src="dist/bundle.js"></script> -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's delete

@mlamchamkee mlamchamkee merged commit 2cefe89 into dev Oct 13, 2022
@mlamchamkee mlamchamkee deleted the bh/dl branch October 13, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants