Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work with projects using /src/ directory #88

Closed
ashtonlance opened this issue Apr 5, 2022 · 3 comments · Fixed by #91
Closed

Doesn't work with projects using /src/ directory #88

ashtonlance opened this issue Apr 5, 2022 · 3 comments · Fixed by #91

Comments

@ashtonlance
Copy link
Contributor

My project has all pages/components/ etc etc under the /src directory. This breaks the whole lighthouse package since it expects /pages to be in the root.
@ashtonlance
Copy link
Contributor Author

I've tried opening a PR but I can't push my branch up due to permission issues.

@mnoah1
Copy link
Contributor

mnoah1 commented Apr 6, 2022

Hi @ashtonlance - did you make the change in your own fork? If so, then from within the fork are you able to select your fork as the head and this repo as the base repository? Or can you provide any other details on the permissions error?

This was referenced Apr 6, 2022
Open
Closed
@ashtonlance
Copy link
Contributor Author

@mnoah1 PR is opened! #91

@ashtonlance ashtonlance mentioned this issue Apr 7, 2022
Merged
@mnoah1 mnoah1 closed this as completed in #91 Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add setting to use src directory ashtonlance/Vantage
2 participants
@ashtonlance @mnoah1