Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic linux perf capture working #128

Merged
merged 5 commits into from Sep 6, 2022
Merged

Basic linux perf capture working #128

merged 5 commits into from Sep 6, 2022

Conversation

seadubs
Copy link
Contributor

@seadubs seadubs commented Sep 6, 2022

Change appController to not use a subshell when starting processes to ensure we get the PID of the actual node app.
Add perfController, similar to dtraceController
Update routers

@seadubs seadubs added the feature New feature or request label Sep 6, 2022
@seadubs seadubs added this to the 1.2.0 milestone Sep 6, 2022
@seadubs
Copy link
Contributor Author

seadubs commented Sep 6, 2022

Note: this depends on having the appropriate perf sysctl settings in place, not sudo. We'll need to update the envController check appropriately.

@seadubs seadubs added the don't merge Issue with PR - DO NOT MERGE label Sep 6, 2022
@seadubs seadubs removed the don't merge Issue with PR - DO NOT MERGE label Sep 6, 2022
Copy link
Contributor

@dzidupe dzidupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great job!

@seadubs seadubs merged commit 2bde0c2 into dev Sep 6, 2022
@seadubs seadubs deleted the feature/linux-perf-support branch September 6, 2022 15:30
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants