Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outputs incorrect svg data when source svg has 'px', 'rem' or 'em' on height and width attributes as a unit of measurement. #5

Closed
Ghustavh97 opened this issue May 24, 2020 · 1 comment
Closed

Outputs incorrect svg data when source svg has 'px', 'rem' or 'em' on height and width attributes as a unit of measurement. #5

Ghustavh97 opened this issue May 24, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@Ghustavh97
Copy link
Contributor

Ghustavh97 commented May 24, 2020 •
edited
Loading

Example

Source svg

<svg class="bi bi-archive-fill" width="1em" height="1em" viewBox="0 0 16 16" fill="currentColor" xmlns="http://www.w3.org/2000/svg">
  <path fill-rule="evenodd" d="M12.643 15C13.979 15 15 13.845 15 12.5V5H1v7.5C1 13.845 2.021 15 3.357 15h9.286zM6 7a.5.5 0 0 0 0 1h4a.5.5 0 0 0 0-1H6zM.8 1a.8.8 0 0 0-.8.8V3a.8.8 0 0 0 .8.8h14.4A.8.8 0 0 0 16 3V1.8a.8.8 0 0 0-.8-.8H.8z"/>
</svg>

Outputs

Expected SVG Produced SVG
expected result

This is also true when height and width are in px or rem as well.
@Ghustavh97 Ghustavh97 added the bug Something isn't working label May 24, 2020
@Ghustavh97 Ghustavh97 mentioned this issue May 24, 2020
Merged
Ghustavh97 added a commit that referenced this issue May 24, 2020
@Ghustavh97
fix issue #5
392534c
@Ghustavh97
Copy link
Contributor Author

Fixed in #6

@snyk-bot snyk-bot mentioned this issue Aug 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ghustavh97