-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for trees that are too big #2200
Comments
https://overpass-turbo.eu/s/1JWd I suspect this might be interesting for JOSM, for their numerical validation rules (which we synchronize with Osmose). That way it benefits more people ànd people who add those trees get a warning prior to uploading it in the first place. Could you report it to them please? |
Clicked on one where curiously the crown was given a lower value of 35 v 45. The JOSM tool with the measured values plugin gives good indication of crown size, seen many exceeding 150-200 m2. Maybe add a crown/trunk ratio test to home in further, venture to think if a mapper goes into mapping these, both will be tagged. |
I'm not a biologist, so I'm not sure if there's trees where it could be true (a cactus perhaps?). I played around a bit to get some stats though:
node[circumference][diameter_crown][to_float(tag("circumference")) > 3.15*to_float(tag("diameter_crown"))] {
throwWarning: tr("circumference larger than diameter_crown");
} This mapcss rule finds (I think) all 73369 trees with a circumference > 43 m. Still excluding trees measured in feets, inches & other uncommon units of course. node[circumference=~/^([1-9][0-9]{2,}|[4-9][0-9])(\.[0-9]+)?( ?m)?$/][circumference!~/^4[0-3]/] {
throwError: tr("TEST: circumference of new world record");
} |
Another idea I had (I created a MaprouletteChallenge here: https://maproulette.org/browse/challenges/44817) is to check for invalid species. Looking for species without a space " " would be enough (tree species are formed by two words), this would flag elements such as: species=UNKNOWN, this could be deleted |
Note, there is already one, but limited to french. https://github.com/osm-fr/osmose-backend/blob/dev/plugins/TagFix_Tree_Lang_fr.py |
Cool! Species could also be used to suggest leaf_type and leaf_cycle. I created a list with the most popular (in OSM database) trees here: https://wiki.openstreetmap.org/wiki/Tag:natural%3Dtree/List_of_Species |
It sounds like an interesting thing to implement! |
Implements the request at #2200 (comment)
Implements the request at #2200 (comment)
Implements the request at #2200 (comment) See PR discussion about semi_deciduous/semi_evergreen exclusion
@ivanbranco the results of the check of |
According to the Guinness World Records, the greatest circumference for a tree is 43m. I suggest implementing a check for trees with circumferences exceeding this value, as they are likely to be errors.
For instance, we currently have 2001 nodes in the database with a circumference of 45: https://overpass-turbo.eu/s/1JUU. Osmose could suggest to check them and
Another check could be on height. Trees taller than Hyperion (tallest tree in the world with 116m) are likely to be errors.
The text was updated successfully, but these errors were encountered: