"tunnel on suspicious object" for tunnel=culvert

[danfos]

I see that Osmose is reporting "tunnel on suspicious object" for tunnel=culvert, for example:

http://osmose.openstreetmap.fr/en/map/#item=9001&class=9001002&zoom=15&lat=51.8384&lon=4.29955&level=3&tags=&fixable=

I think I could fix this myself but I need some guidance on how.

I see the message is triggered by code in plugins/Josm_combinations.py and that looks like code generated based on mapcss but I do not see which file this was based on.

There is also a comment

    # way[waterway][layer][layer=~/^(-1|-2|-3|-4|-5)$/][!tunnel][culvert!=yes][covered!=yes][pipeline!=yes][location!=underground][eval(waylength())>400]
    # Part of rule not implemented

and that is likely covering this issue.

Any guidance on how to get this fixed?

[ghost]

I believe the problem here is that you're missing the
waterway=XYZ
Tag

[danfos]

I agree that "tunnel=culvert" is most used in combination with waterway=*, water is here mapped as an area with natural=water. Mapping an area of water is not possible with the waterway tags.

If the surrounding water is mapped as natural=water (as is here the case) It makes sense to me to map the water (if it is reasonable wide) in the culvert also as natural=water

[frodrigo]

The source code is from JOSM MapCSS https://josm.openstreetmap.de/browser/josm/trunk/data/validator/combinations.mapcss
If any issue report to JOSM

cc @Klumbumbus

[Klumbumbus]

To me the warning is correct. Similar to bridge=yes also tunnel=yes is meant as property of a linear feature like highways or railways. If you want to map the outline you may use man_made=bridge or man_made=tunnel (proposed, see https://wiki.openstreetmap.org/wiki/Proposed_features/man_made%3Dtunnel)

[frodrigo]

Please, reopen if required.

[danfos]

Good suggestion to use "man_made=tunnel" but I think doing so it is still good to indicate the type of tunnel, just the Wiki says tunnel=building_passage/avalanche_protector

That would mean adding "man_made=tunnel" but keeping "tunnel=culvert"

[Klumbumbus]

OK, after https://josm.openstreetmap.de/changeset/15595/josmit it no longer warns about tunnel=* on man_made=tunnel however it warns about the special cases tunnel=yes on man_made=tunnel and also bridge=yes on man_made=bridge as these are not useful combinations.

[Klumbumbus]

(it seems reopening this issue is not allowed)

[danfos]

Thanks for the rapid fix, good to have.

I guess Osmose merges these changes in JOSM periodically, having this issue open would be a good reminder for that I think.

[frodrigo]

Manually update.

I prefer do not track issues on remote fixed code here.

[danfos]

Is updating Osmose a matter of getting the latest version of josm/trunk/data/validator/combinations.mapcss through mapcss2osmose.py?

If so, I could make a PR for it.

[frodrigo]

Yes. But its undocumented.

[danfos]

I did that before for #680, can do it for this.

[frodrigo]

I made the update. It is in the pipe line.