Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add country analyzer name in table loaded from dynamic merge #1854

Merged
merged 1 commit into from
May 8, 2023

Conversation

frodrigo
Copy link
Member

@frodrigo frodrigo commented May 6, 2023

Add country analyzer name in table loaded from dynamic merge to avoid conflict on cached tables

@frodrigo frodrigo requested a review from jocelynj May 6, 2023 20:08
@jocelynj
Copy link
Member

jocelynj commented May 6, 2023

Could it increase the storage needed on backends?

It might if an opendata source is shared between several regions, and we don't filter by area on import to the database.

@frodrigo
Copy link
Member Author

frodrigo commented May 7, 2023

Could it increase the storage needed on backends?

Theoretically yes.

It might if an opendata source is shared between several regions, and we don't filter by area on import to the database.

But in practice, all data source based on GDAL are filtered by polygon before load. And other country wide datasets are run on osm110.

I think there will be no storage increasement.

A next improvement could be to base all loaders on GDAL.

@jocelynj jocelynj merged commit eb4a115 into osm-fr:dev May 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants