Fix flake8 issues #2393
Merged
Fix flake8 issues #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found by flake8.
Use psycopg2 formatting to ensure correct quoting.
Make psycopg2's convenience function accessible through the cursor.
Use the SQL formatting supplied with psycopg whenever the query needs to be put together from snippets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes code smells and potential security issues found by flake8/flake8-bugbear/flake8-bandit. The code smells mostly relate to code formatting. On the security side, the fixes provide more safe SQL command construction using psycopg2's sql module were possible. This brings us better quoting of variable and table names.
Altogether flake8 looks useful but has too many false positives to be suitable for CI integration. So it's rather something to run locally now and then.