Check more user-supplied strings used as SQL identifier #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a couple of other places outside the flex output where we should check that psql identifiers are correctly quotable.
Adds checks for the prefix and schema commandline parameters and for column names and types from the pgsql style file.
joto
reviewed
Sep 9, 2022
src/pgsql.cpp
Outdated
|
|
||
| throw std::runtime_error{ | ||
| "Special characters are not allowed in {} names: '{}'."_format(in, | ||
| name)}; |
There was a problem hiding this comment.
The message can now be confusing, for instance for the --prefix option it will say:
Special characters are not allowed in prefix names: '...'. . Maybe just remove the names?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already consistently quote all identifier used in SQL strings in the code to avoid SQL injection issues. The quoting works on the assumption that there are no double quotes in the string itself. The flex output already checked all user-supplied strings for conformance.
This PR adds the same check to the prefix and schema command-line parameters which are used as SQL identifiers and for the column names and types from the pgsql style file.