This repository has been archived by the owner on Dec 26, 2017. It is now read-only.
Use only OSM data for oceans #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW. @stirringhalo what was the reason that we subdivide the ocean polygons as well? (according to OpenStreetMap data they should already be split). |
|
@lukasmartinelli , I went through and checked the vertex counts in some of the tables which I suspected had large features. Oceans was one of them. I noticed in https://github.com/stirringhalo/openstreetmap-mapboxgl that Oceans were already subdivided thoroughly. You can also see that in an "official" openstreetmap import, glaciers are also split too (http://45.56.99.211/) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer use NE data for ocean but simplify OpenStreetMapData water polygons even more. Fixes #329.