Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report version in user agent http header on OSM-API calls #845

Closed
tyrasd opened this issue Sep 16, 2020 · 1 comment · Fixed by #853
Closed

report version in user agent http header on OSM-API calls #845

tyrasd opened this issue Sep 16, 2020 · 1 comment · Fixed by #853
Assignees
@nnngrach
Milestone
3.80-iOS

Comments

@tyrasd
Copy link

tyrasd commented Sep 16, 2020 •
edited
Loading

From https://operations.osmfoundation.org/policies/api/ (highlighting below by me):

Technical Usage Requirements: Valid User-Agent identifying application and version. […]

Currently, as far as I can see in the code and from what I read in https://www.openstreetmap.org/user/stragu/diary/394199#comment48153, the app does only report its name, but not its version number.

//edit: the relevant code should be here, if I'm not mistaken: https://github.com/osmandapp/OsmAnd-iOS/blob/r3.14/Sources/OsmEdit/OAOpenStreetMapRemoteUtil.mm#L79
@vshcherb vshcherb added this to the 3.80-iOS milestone Sep 16, 2020
@vshcherb
Copy link
Member

Agree

@nnngrach nnngrach mentioned this issue Sep 17, 2020
Merged
@nnngrach nnngrach linked a pull request Sep 17, 2020 that will close this issue
add version to user agent #853
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nnngrach nnngrach

Labels
None yet
Projects
None yet
Milestone
3.80-iOS
Development

Successfully merging a pull request may close this issue.

add version to user agent osmandapp/OsmAnd-iOS
3 participants
@vshcherb @tyrasd @nnngrach