Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osm routes tags #3472

Merged
merged 4 commits into from
Mar 4, 2024
Merged

osm routes tags #3472

merged 4 commits into from
Mar 4, 2024

Conversation

Skalii
Copy link
Contributor

@Skalii Skalii commented Feb 29, 2024

No description provided.

@Skalii Skalii linked an issue Feb 29, 2024 that may be closed by this pull request
9 tasks

NSString *routeTagValue = i.value().toNSString();
if ([routeTagKey isEqualToString:@"ascent"] || [routeTagKey isEqualToString:@"descent"])
routeTagValue = [NSString stringWithFormat:@"%@ %@", routeTagValue, OALocalizedString(@"m")];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization key is missing. - "m"

if ([routeTagKey isEqualToString:@"ascent"] || [routeTagKey isEqualToString:@"descent"])
routeTagValue = [NSString stringWithFormat:@"%@ %@", routeTagValue, OALocalizedString(@"m")];
else if ([routeTagKey isEqualToString:@"distance"])
routeTagValue = [NSString stringWithFormat:@"%@ %@", routeTagValue, OALocalizedString(@"km")];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization key is missing. -"km"

@alex-osm alex-osm merged commit 5be25f8 into master Mar 4, 2024
@alex-osm alex-osm deleted the gpx_osm_routes_tags branch March 4, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for additional tags for OSM routes
3 participants