Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenGL + live: Duplicated data rendered #14920

Closed
scaidermern opened this issue Jul 23, 2022 · 20 comments · Fixed by osmandapp/OsmAnd-core#544 or osmandapp/OsmAnd-core#550
Closed

OpenGL + live: Duplicated data rendered #14920

scaidermern opened this issue Jul 23, 2022 · 20 comments · Fixed by osmandapp/OsmAnd-core#544 or osmandapp/OsmAnd-core#550
Assignees
@ivanPyrohivskyi @cepprice
Labels
opengl
Milestone
4.5-backend

Comments

@scaidermern
Copy link
Contributor

scaidermern commented Jul 23, 2022 •
edited by Zirochkabila

With enabled OpenGL rendering and OsmAnd live duplicated data is rendered (probably old + new data).

Example:
geo:51.56373,13.00119?z=19

Both the upper and the lower path are rendered twice.

Same problem here:
geo:51.55929,12.99431?z=18

Deleting and redownloading live data or restarting OsmAnd doesn't fix the problem.

Disabling OpenGL or disabling OsmAnd live does fix the problem.

OsmAnd 4.2.7.
@scaidermern
Copy link
Contributor Author

scaidermern commented Jul 26, 2022 •
edited by Zirochkabila

This also happens to other way types, to buildings etc:

geo:51.34647,12.38865?z=20

This doesn't always happen. If it doesn't happen then restarting OsmAnd immediately leads to this behavior.

@Zirochkabila
Copy link
Collaborator

reproduce on 4.3.0#13675mqta, released: 2022-07-28 and 4.2.7, released: 2022-07-13 versions. But just when used Live Updates

@vshcherb vshcherb added this to the 4.3-backend milestone Jul 28, 2022
@Zirochkabila
Copy link
Collaborator

Zirochkabila commented Jul 28, 2022 •
edited

https://drive.google.com/drive/folders/10FBvmQrbeS3zis0glSNBNOeCY-bBoarJ?usp=sharing

Maps

@franco999
Copy link
Contributor

The same thing happens to me. It happens that live updates are not displayed or are not superimposed correctly and then you have to restart Osmand 1-3 times after which the problem disappears temporary. I use nightly build OsmAnd~ 4.3.0#13751mqta, (2022-09-03) and OpenGL on.

@vshcherb vshcherb modified the milestones: 4.3-backend, 4.4-backend Oct 1, 2022
@vshcherb vshcherb mentioned this issue Nov 17, 2022
Closed
@vshcherb
Copy link
Member

#14339

@scaidermern scaidermern mentioned this issue Dec 22, 2022
Closed
@scaidermern scaidermern mentioned this issue Jan 19, 2023
Closed
@scaidermern scaidermern mentioned this issue Feb 5, 2023
Closed
@MeijiRestored
Copy link
Contributor

Still happens on 4.4.0#14151mqta

Screenrecorder-2023-02-05-18-54-15-643.mp4

@mikehgentry mikehgentry mentioned this issue Mar 5, 2023
Closed
@scaidermern scaidermern mentioned this issue Mar 10, 2023
Closed
@scaidermern scaidermern mentioned this issue Apr 13, 2023
Closed
@Nine-Tailed
Copy link
Contributor

Another video demonstrating the problem of duplication and incorrect rendering of objects that got into the live update.
Video from ruosmand chat in telegram
https://t.me/ruosmand/122530

@Zirochkabila
Copy link
Collaborator

OsmAnd~ 4.5.0#35830m, Released: 2023-04-23
In the latest nightly version and with the latest maps updates, it was not possible to reproduce user requests - the data is displayed similarly to that on OSM, without duplication

@Zirochkabila Zirochkabila mentioned this issue Apr 24, 2023
Closed
@Nine-Tailed
Copy link
Contributor

OsmAnd~ 4.5.0#35830m, Released: 2023-04-23
In the latest nightly version and with the latest maps updates, it was not possible to reproduce user requests - the data is displayed similarly to that on OSM, without duplication

Objects are still duplicated, but restarting helps. Pay attention after the restart, the duplication seems to be gone, but strange bugs are observed when scaling.
OsmAnd~ 4.5.0#35835m, Дата выпуска: 2023-04-24
https://t.me/ruosmand/122930

@Zirochkabila
Copy link
Collaborator

OsmAnd~ 4.5.0#35830m, Released: 2023-04-23
Can only be reproduced with Live Updates

Data on the map before and after the reopening differ
55.70107° N, 37.36068° E

Entrance changes its location
55.70084° N, 37.35867° E

telegram-cloud-document-2-5346162637640052190.mp4

@Zirochkabila Zirochkabila mentioned this issue Apr 25, 2023
Closed
4 tasks
@vshcherb vshcherb modified the milestones: next-backend, 4.5-backend Apr 25, 2023
cepprice added a commit to osmandapp/OsmAnd-core that referenced this issue May 3, 2023
@cepprice
Read OBFs of live updates in date order osmandapp/OsmAnd#14920
28b711a
@cepprice cepprice linked a pull request May 3, 2023 that will close this issue
Read OBFs of live updates in date order osmandapp/OsmAnd-core#544
Merged
@Nine-Tailed
Copy link
Contributor

Good news, will have to check.

@Nine-Tailed
Copy link
Contributor

The problem seems to be unresolved (OsmAnd~ 4.5.0#35904m, Дата выпуска: 2023-05-07).
Link to one of the houses with rendering issue: https://www.openstreetmap.org/way/404783647
https://user-images.githubusercontent.com/12549744/236701288-0c2bec7e-c357-44de-b1fe-cbb4a14c736f.mp4

@Zirochkabila
Copy link
Collaborator

Zirochkabila commented May 8, 2023 •
edited

OsmAnd~ 4.5.0#35905m, Released: 2023-05-08
4.4.8.5
Ask me maps

55.68777, 37.33968

When using Live updates and V2, a road chat and a house chat appear
V1 - works normally

Without Live Live iOS
telegram-cloud-document-2-5389118821770472482.mp4
telegram-cloud-document-2-5389118821770472484.mp4
telegram-cloud-document-2-5389118821770472498.mp4

@Zirochkabila Zirochkabila reopened this May 8, 2023
@ivanPyrohivskyi
Copy link
Contributor

Need to expand bbox during reading obf. From 15 zoom.

cepprice added a commit to osmandapp/OsmAnd-core that referenced this issue May 14, 2023
@cepprice
Fix showing deleted objects in live updates osmandapp/OsmAnd#14920
cbcbf48
@cepprice cepprice linked a pull request May 14, 2023 that will close this issue
Fix showing deleted objects in live updates osmandapp/OsmAnd-core#550
Merged
@Nine-Tailed
Copy link
Contributor

Nine-Tailed commented May 19, 2023 •
edited

Found another bug, maybe it is related to the previous one:
https://osmand.net/map?pin=55.68753,37.34513#20/55.68753/37.34513
https://github.com/osmandapp/OsmAnd/assets/12549744/b6c172b7-0d78-440f-8325-621725df59ed

@Nine-Tailed
Copy link
Contributor

One more place:
https://osmand.net/map?pin=55.64136,37.57937#17/55.64136/37.57937
See video:
https://t.me/ruosmand/124409

@Zirochkabila Zirochkabila reopened this May 21, 2023
@Zirochkabila
Copy link
Collaborator

OsmAnd~ 4.5.0#56m, Released: 2023-05-20
Best seen with Topo map styles
Ask me map

55.64172° N, 37.57949° E

telegram-cloud-document-2-5427298177634019475.mp4

@scaidermern scaidermern mentioned this issue May 24, 2023
Closed
@Nine-Tailed
Copy link
Contributor

Has this bug been fixed? I still continue to watch him in the night build of OsmAnd~ 4.5.0#91m, release: 2023-05-25.

@vshcherb
Copy link
Member

Original bug is fixed, I don't see any duplicate roads on the same screen. Anyway it could be unrelated issue to this one

@Nine-Tailed Nine-Tailed mentioned this issue May 26, 2023
Closed
@ivanPyrohivskyi
Copy link
Contributor

OsmAnd~ 4.5.0#56m, Released: 2023-05-20 Best seen with Topo map styles Ask me map

55.64172° N, 37.57949° E
telegram-cloud-document-2-5427298177634019475.mp4

Moved to #17282

cepprice added a commit to osmandapp/OsmAnd-core that referenced this issue Jun 5, 2023
@cepprice
Revert "Read OBFs of live updates in date order osmandapp/OsmAnd#14920"
e0cd581 
This reverts commit 28b711a.
@scaidermern scaidermern mentioned this issue Jun 30, 2023
Closed
@scaidermern scaidermern mentioned this issue Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanPyrohivskyi ivanPyrohivskyi

@cepprice cepprice

Labels
opengl
Projects
None yet
Milestone
4.5-backend
8 participants
@ivanPyrohivskyi @scaidermern @vshcherb @franco999 @Nine-Tailed @cepprice @MeijiRestored @Zirochkabila